gtk platform doesn't support link prefetch

• Component: DOM
• Status: RESOLVED FIXED

[Gavin Peters]

The configure script used for the GTK platform doesn't at present pass through the link prefetch feature in WebKit.  It probably should.

[Gavin Peters]

Created attachment 73336 [details]
Patch

[Gavin Peters]

Xan,

Can you look at this?  Manual testing shows that it works with build-webkit and ./configure, and prefetch validation sites show it working.

[Xan Lopez]

Comment on attachment 73336 [details]
Patch

>+AM_CONDITIONAL([ENABLE_LINK_PREFETCH],[test "$enable_link_prefetch" = "yes"])

I think you only need this if you are going to use the variable in a makefile. Since you won't it's unneeded.

> 
> # Gtk conditionals
> AM_CONDITIONAL([ENABLE_INTROSPECTION],[test "$enable_introspection" = "yes"])
>@@ -1027,6 +1039,7 @@ Features:
>  XHTML-MP support                                         : $enable_xhtmlmp
>  XPATH support                                            : $enable_xpath
>  XSLT support                                             : $enable_xslt
>+ Link prefetch support                                    : $enable_link_prefetch

This should be in alphabetical order.

> GTK+ configuration:
>  GTK+ version                                             : $with_gtk
>  GDK target                                               : $with_target

r- for those reasons, thanks for the patch.

[Gavin Peters]

Created attachment 73338 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 73338 [details]
Patch

Clearing flags on attachment: 73338

Committed r71620: <http://trac.webkit.org/changeset/71620>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/71620 might have broken GTK Linux 64-bit Debug
The following tests are not passing:
fast/text/international/plane2.html