Bug 49234

Summary: gtk platform doesn't support link prefetch
Product: WebKit Reporter: Gavin Peters <gavinp>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch none

Gavin Peters
Reported 2010-11-08 18:59:50 PST
The configure script used for the GTK platform doesn't at present pass through the link prefetch feature in WebKit. It probably should.
Attachments
Patch (2.30 KB, patch)
2010-11-08 19:03 PST, Gavin Peters 		no flags
DetailsFormatted DiffDiff
Patch (2.34 KB, patch)
2010-11-08 20:05 PST, Gavin Peters 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gavin Peters
Comment 1 2010-11-08 19:03:44 PST
Created attachment 73336 [details] Patch
Gavin Peters
Comment 2 2010-11-08 19:06:19 PST
Xan, Can you look at this? Manual testing shows that it works with build-webkit and ./configure, and prefetch validation sites show it working.
Xan Lopez
Comment 3 2010-11-08 19:43:28 PST
Comment on attachment 73336 [details] Patch >+AM_CONDITIONAL([ENABLE_LINK_PREFETCH],[test "$enable_link_prefetch" = "yes"]) I think you only need this if you are going to use the variable in a makefile. Since you won't it's unneeded. > > # Gtk conditionals > AM_CONDITIONAL([ENABLE_INTROSPECTION],[test "$enable_introspection" = "yes"]) >@@ -1027,6 +1039,7 @@ Features: > XHTML-MP support : $enable_xhtmlmp > XPATH support : $enable_xpath > XSLT support : $enable_xslt >+ Link prefetch support : $enable_link_prefetch This should be in alphabetical order. > GTK+ configuration: > GTK+ version : $with_gtk > GDK target : $with_target r- for those reasons, thanks for the patch.
Gavin Peters
Comment 4 2010-11-08 20:05:47 PST
Created attachment 73338 [details] Patch
WebKit Commit Bot
Comment 5 2010-11-09 04:05:16 PST
Comment on attachment 73338 [details] Patch Clearing flags on attachment: 73338 Committed r71620: <http://trac.webkit.org/changeset/71620>
WebKit Commit Bot
Comment 6 2010-11-09 04:05:20 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 7 2010-11-09 05:35:02 PST
http://trac.webkit.org/changeset/71620 might have broken GTK Linux 64-bit Debug The following tests are not passing: fast/text/international/plane2.html
Note You need to log in before you can comment on or make changes to this bug.