|Summary:||gtk platform doesn't support link prefetch|
|Product:||WebKit||Reporter:||Gavin Peters <gavinp>|
|Severity:||Normal||CC:||abarth, commit-queue, eric, webkit.review.bot, xan.lopez|
|Version:||528+ (Nightly build)|
Description Gavin Peters 2010-11-08 18:59:50 PST
The configure script used for the GTK platform doesn't at present pass through the link prefetch feature in WebKit. It probably should.
Comment 2 Gavin Peters 2010-11-08 19:06:19 PST
Xan, Can you look at this? Manual testing shows that it works with build-webkit and ./configure, and prefetch validation sites show it working.
Comment 3 Xan Lopez 2010-11-08 19:43:28 PST
Comment on attachment 73336 [details] Patch >+AM_CONDITIONAL([ENABLE_LINK_PREFETCH],[test "$enable_link_prefetch" = "yes"]) I think you only need this if you are going to use the variable in a makefile. Since you won't it's unneeded. > > # Gtk conditionals > AM_CONDITIONAL([ENABLE_INTROSPECTION],[test "$enable_introspection" = "yes"]) >@@ -1027,6 +1039,7 @@ Features: > XHTML-MP support : $enable_xhtmlmp > XPATH support : $enable_xpath > XSLT support : $enable_xslt >+ Link prefetch support : $enable_link_prefetch This should be in alphabetical order. > GTK+ configuration: > GTK+ version : $with_gtk > GDK target : $with_target r- for those reasons, thanks for the patch.
Comment 5 WebKit Commit Bot 2010-11-09 04:05:16 PST
Comment on attachment 73338 [details] Patch Clearing flags on attachment: 73338 Committed r71620: <http://trac.webkit.org/changeset/71620>
Comment 6 WebKit Commit Bot 2010-11-09 04:05:20 PST
All reviewed patches have been landed. Closing bug.