Bug 49231

Summary: getAttachedShaders should only return null (not undefined) on error
Product: WebKit Reporter: Adrienne Walker <enne>
Component: WebGLAssignee: Adrienne Walker <enne>
Severity: Normal CC: commit-queue, enne, kbr
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
Patch none

Description Adrienne Walker 2010-11-08 18:31:01 PST
Currently gl-object-get-calls allows getAttachedShaders to return undefined or null in the case of an error.  It should only allow null.

This is to fix a minor issue from https://bugs.webkit.org/show_bug.cgi?id=48962.
Comment 1 Adrienne Walker 2010-11-08 18:33:51 PST
Created attachment 73330 [details]
Comment 2 Adrienne Walker 2010-11-08 18:35:09 PST
(In reply to comment #1)
> Created an attachment (id=73330) [details]
> Patch

Already updated in the Khronos repository.  Tested on 10.6.
Comment 3 Andreas Kling 2010-11-09 00:21:50 PST
Comment on attachment 73330 [details]

Comment 4 WebKit Commit Bot 2010-11-09 00:58:57 PST
Comment on attachment 73330 [details]

Clearing flags on attachment: 73330

Committed r71615: <http://trac.webkit.org/changeset/71615>
Comment 5 WebKit Commit Bot 2010-11-09 00:59:01 PST
All reviewed patches have been landed.  Closing bug.