Bug 49231

Summary: getAttachedShaders should only return null (not undefined) on error
Product: WebKit Reporter: Adrienne Walker <enne>
Component: WebGLAssignee: Adrienne Walker <enne>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, enne, kbr
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Adrienne Walker
Reported 2010-11-08 18:31:01 PST
Currently gl-object-get-calls allows getAttachedShaders to return undefined or null in the case of an error. It should only allow null. This is to fix a minor issue from https://bugs.webkit.org/show_bug.cgi?id=48962.
Attachments
Patch (2.39 KB, patch)
2010-11-08 18:33 PST, Adrienne Walker 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adrienne Walker
Comment 1 2010-11-08 18:33:51 PST
Created attachment 73330 [details] Patch
Adrienne Walker
Comment 2 2010-11-08 18:35:09 PST
(In reply to comment #1) > Created an attachment (id=73330) [details] > Patch Already updated in the Khronos repository. Tested on 10.6.
Andreas Kling
Comment 3 2010-11-09 00:21:50 PST
Comment on attachment 73330 [details] Patch LGTM
WebKit Commit Bot
Comment 4 2010-11-09 00:58:57 PST
Comment on attachment 73330 [details] Patch Clearing flags on attachment: 73330 Committed r71615: <http://trac.webkit.org/changeset/71615>
WebKit Commit Bot
Comment 5 2010-11-09 00:59:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.