Bug 49231 - getAttachedShaders should only return null (not undefined) on error
Summary: getAttachedShaders should only return null (not undefined) on error
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Adrienne Walker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-08 18:31 PST by Adrienne Walker
Modified: 2010-11-09 00:59 PST (History)
3 users (show)

See Also:

Attachments
Patch (2.39 KB, patch)
2010-11-08 18:33 PST, Adrienne Walker 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrienne Walker 2010-11-08 18:31:01 PST 
Currently gl-object-get-calls allows getAttachedShaders to return undefined or null in the case of an error.  It should only allow null.

This is to fix a minor issue from https://bugs.webkit.org/show_bug.cgi?id=48962.
Comment 1 Adrienne Walker 2010-11-08 18:33:51 PST 
Created attachment 73330 [details]
Patch
Comment 2 Adrienne Walker 2010-11-08 18:35:09 PST 
(In reply to comment #1)
> Created an attachment (id=73330) [details]
> Patch

Already updated in the Khronos repository.  Tested on 10.6.
Comment 3 Andreas Kling 2010-11-09 00:21:50 PST 
Comment on attachment 73330 [details]
Patch

LGTM
Comment 4 WebKit Commit Bot 2010-11-09 00:58:57 PST 
Comment on attachment 73330 [details]
Patch

Clearing flags on attachment: 73330

Committed r71615: <http://trac.webkit.org/changeset/71615>
Comment 5 WebKit Commit Bot 2010-11-09 00:59:01 PST 
All reviewed patches have been landed.  Closing bug.