Bug 49223

Summary: dump-as-markup conversion: editing/inserting/5607069-2.html and 5607069-3.html
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Enhancement CC: enrica, mrobinson, ojan, tkent, tonikitoo, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
converted tests
none
fixed the test description tkent: review+

Ryosuke Niwa
Reported 2010-11-08 16:34:13 PST
editing/inserting/5607069-2.html and editing/inserting/5607069-3.html should be dump-as-markup or dump-as-text tests. We don't care so much about the rendering but we do care about the resultant DOM.
Attachments
converted tests (20.20 KB, patch)
2010-11-08 17:06 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
fixed the test description (20.19 KB, patch)
2010-11-08 17:49 PST, Ryosuke Niwa 		tkent: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2010-11-08 17:05:59 PST
+tonikitoo & mrobinson since I'm attending to reenable these tests on Gtk & Qt as well.
Ryosuke Niwa
Comment 2 2010-11-08 17:06:15 PST
Created attachment 73311 [details] converted tests
Kent Tamura
Comment 3 2010-11-08 17:13:28 PST
Comment on attachment 73311 [details] converted tests View in context: https://bugs.webkit.org/attachment.cgi?id=73311&action=review > LayoutTests/editing/inserting/5607069-2.html:7 > +Markup.description("This tests for a bug where InsertLineBreak would insert a '\\n' instead of a <br> if the caret was set just before an input field. You should see two input fields each in its own paragraph below."); We had better update the description text so that it mentions <br> between two <input>s. > LayoutTests/editing/inserting/5607069-3.html:7 > +Markup.description("This tests for a bug in InsertParagraph where it would split and clone a <form> element in the same way it would a <p> or a <div>. You should see two paragraphs below both inside the form (blue bordered) element."); ditto. like "<br> between two x". "blue border" seems to make no sense in dump-as-markup.
Ryosuke Niwa
Comment 4 2010-11-08 17:49:17 PST
Created attachment 73324 [details] fixed the test description
Ryosuke Niwa
Comment 5 2010-11-08 17:50:07 PST
(In reply to comment #3) > (From update of attachment 73311 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=73311&action=review > > > LayoutTests/editing/inserting/5607069-2.html:7 > > +Markup.description("This tests for a bug where InsertLineBreak would insert a '\\n' instead of a <br> if the caret was set just before an input field. You should see two input fields each in its own paragraph below."); > > We had better update the description text so that it mentions <br> between two <input>s. Done. > > LayoutTests/editing/inserting/5607069-3.html:7 > > +Markup.description("This tests for a bug in InsertParagraph where it would split and clone a <form> element in the same way it would a <p> or a <div>. You should see two paragraphs below both inside the form (blue bordered) element."); > > ditto. like "<br> between two x". > "blue border" seems to make no sense in dump-as-markup. Done.
Kent Tamura
Comment 6 2010-11-08 17:58:16 PST
Comment on attachment 73324 [details] fixed the test description ok
Ryosuke Niwa
Comment 7 2010-11-08 18:46:00 PST
Committed r71595: <http://trac.webkit.org/changeset/71595>
Note You need to log in before you can comment on or make changes to this bug.