Bug 49175

Summary:

Building for Android generates several compiler warnings

Product:

WebKit

Reporter:

Steve Block <steveblock>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

phanna, steveblock

Priority:

Version:

528+ (Nightly build)

Hardware:

Android

OS:

Android

Attachments:

Description	Flags
Patch	levin: review+, levin: commit-queue-

Description Steve Block 2010-11-08 07:18:19 PST

These are due to signed/unsigned comparisons, assignment in if statements, braces in logical statements, and redefinition of macros.

Comment 1 Steve Block 2010-11-08 07:46:17 PST

Created attachment 73239 [details]
Patch

Comment 2 David Levin 2010-11-08 11:21:59 PST

Comment on attachment 73239 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=73239&action=review

Please fix typos in changelog.

> WebCore/ChangeLog:9
> +        - PREFIX_FOR_WEBCORE was previously required for STL's algirithm, but is no

typo: algirithm

> WebCore/ChangeLog:15
> +        No new tests, fixes compile arnings only.

typo: arnings

Comment 3 Steve Block 2010-11-08 14:52:54 PST

Committed r71578: <http://trac.webkit.org/changeset/71578>