Bug 49155

Summary:

Remove the remaining editing-style functions from ApplyStyleCommand

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

HTML Editing

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

darin, eric, ojan, tony

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

46335

Bug Blocks:

Attachments:

Description	Flags
cleanup	darin: review+

Description Ryosuke Niwa 2010-11-07 20:22:44 PST

This is a follow up to the bug 46335, which introduced EditingStyle.  In this follow up, we remove removeNonEditingProperties, editingStyleAtPosition, prepareEditingStyleToApplyAt, and removeStylesAddedByNode from ApplyStyleCommand.cpp/h.

Comment 1 Ryosuke Niwa 2010-11-07 22:04:11 PST

Created attachment 73211 [details]
cleanup

Comment 2 Darin Adler 2010-11-08 10:43:40 PST

Comment on attachment 73211 [details]
cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=73211&action=review

Seems good. Refactoring looks like it was done correctly.

> WebCore/editing/EditingStyle.h:72
> +    void removeStyleAddedByNode(Node* node);
> +    void removeStyleConflictingWithStyleOfNode(Node* node);

No need for argument names here in these function declarations.

Comment 3 Ryosuke Niwa 2010-11-08 12:15:51 PST

Committed r71556: <http://trac.webkit.org/changeset/71556>