Summary: | Assert that a non-null PassRefPtr<Document> has a non-null frame in Frame::setDocument() | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||
Component: | WebCore Misc. | Assignee: | Daniel Bates <dbates> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, ap, commit-queue | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Daniel Bates
2010-11-07 18:38:24 PST
Created attachment 73201 [details]
Patch
This change does not cause any DRT regressions on my Mac.
As far as I can tell from looking at the callers of Frame::setDocument() and the Document creation process, it doesn't make sense for Frame::setDocument() to be passed a non-null PassRefPtr<Document> whose Document has a null frame (i.e. Document::frame() == 0).
Created attachment 73202 [details]
Patch
Updated title of bug in change log.
Comment on attachment 73202 [details]
Patch
Thanks.
Comment on attachment 73202 [details]
Patch
Will land by hand.
Committed r71493: <http://trac.webkit.org/changeset/71493> |