Bug 49126

Summary: RenderBlock::positionForPoint is not writing-mode-aware.
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, ossy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 46123    
Attachments:
Description Flags
Patch mitz: review+

Description Dave Hyatt 2010-11-05 22:56:23 PDT 
RenderBlock::positionForPoint is not writing-mode-aware.
Comment 1 Dave Hyatt 2010-11-08 12:25:46 PST 
Created attachment 73266 [details]
Patch
Comment 2 mitz 2010-11-08 13:03:33 PST 
Comment on attachment 73266 [details]
Patch

r=me (with a renaming of IntPoint::transpose())
Comment 3 Dave Hyatt 2010-11-08 13:13:33 PST 
Fixed in r71563.
Comment 4 WebKit Review Bot 2010-11-08 13:41:33 PST 
http://trac.webkit.org/changeset/71563 might have broken Qt Linux Release
The following tests are not passing:
editing/selection/move-by-line-003.html
fast/dom/Document/CaretRangeFromPoint/replace-element.html
Comment 5 Csaba Osztrogonác 2010-11-08 15:01:07 PST 
(In reply to comment #4)
> http://trac.webkit.org/changeset/71563 might have broken Qt Linux Release
> The following tests are not passing:
> editing/selection/move-by-line-003.html
> fast/dom/Document/CaretRangeFromPoint/replace-element.html

Not only the Qt bot, the whole world :(
Comment 6 Dave Hyatt 2010-11-08 15:59:00 PST 
Fixed the Ruby issue.

Regression test issue tracked in

https://bugs.webkit.org/show_bug.cgi?id=49217