Bug 49125

Summary: [EFL] Add option to enable Touch Events.
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: antognolli+webkit, commit-queue, kenneth, leandro, lucas.de.marchi, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Updated patch fixing comments of Kenneth none

Ryuan Choi
Reported 2010-11-05 22:31:48 PDT
[CMake] Add option to enable Touch Events.
Attachments
Patch (14.47 KB, patch)
2010-11-22 22:44 PST, Ryuan Choi
no flags
Updated patch fixing comments of Kenneth (14.47 KB, patch)
2010-11-23 04:54 PST, Ryuan Choi
no flags
Ryuan Choi
Comment 1 2010-11-22 22:44:40 PST
Kenneth Rohde Christiansen
Comment 2 2010-11-23 01:01:24 PST
Comment on attachment 74633 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=74633&action=review > WebCore/platform/efl/PlatformTouchEventEfl.cpp:36 > +namespace WebCore { > +PlatformTouchEvent::PlatformTouchEvent(Eina_List* points, const IntPoint pos, TouchEventType type, int metaState) Shouldn't there be some newline here? > WebCore/platform/efl/PlatformTouchEventEfl.cpp:68 > + // FIXME: We don't support metaState now. 'for now' > WebKit/efl/WebCoreSupport/ChromeClientEfl.h:126 > +#if ENABLE(TOUCH_EVENTS) > + virtual void needTouchEvents(bool) { } > +#endif > + What is that bool for? > WebKit/efl/ewk/ewk_frame.cpp:1481 > +#if ENABLE(TOUCH_EVENTS) I would add a newline before this one
Ryuan Choi
Comment 3 2010-11-23 04:54:09 PST
Created attachment 74645 [details] Updated patch fixing comments of Kenneth
Ryuan Choi
Comment 4 2010-11-23 05:05:27 PST
(In reply to comment #3) > Created an attachment (id=74645) [details] > Updated patch fixing comments of Kenneth Dear Kenneth, Thank you for you reviewing and I fixed all you mentioned. > > WebKit/efl/WebCoreSupport/ChromeClientEfl.h:126 > > +#if ENABLE(TOUCH_EVENTS) > > + virtual void needTouchEvents(bool) { } > > +#endif > > + > > What is that bool for? This function is for WebCore to inform the platform when it needs touch events. (https://bugs.webkit.org/show_bug.cgi?id=34215) We probably need this, but not now.
WebKit Commit Bot
Comment 5 2010-12-24 03:28:09 PST
Comment on attachment 74645 [details] Updated patch fixing comments of Kenneth Clearing flags on attachment: 74645 Committed r74626: <http://trac.webkit.org/changeset/74626>
WebKit Commit Bot
Comment 6 2010-12-24 03:28:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.