Bug 49124

Summary: Inline some DeprecatedPtrListImplIterator methods for performance
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: NEW    
Severity: Normal CC: eric, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Simon Fraser (smfr)
Reported 2010-11-05 21:38:40 PDT
Inline some DeprecatedPtrListImplIterator methods for performance
Attachments
Patch (3.43 KB, patch)
2010-11-05 21:39 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2010-11-05 21:39:15 PDT
Created attachment 73163 [details] Patch
Dave Hyatt
Comment 2 2010-11-05 21:40:29 PDT
Comment on attachment 73163 [details] Patch r=me
WebKit Review Bot
Comment 3 2010-11-05 21:42:39 PDT
Attachment 73163 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebCore/ChangeLog', u'WebCore/platform/DeprecatedPtrListImpl.cpp', u'WebCore/platform/DeprecatedPtrListImpl.h']" exit_code: 1 WebCore/platform/DeprecatedPtrListImpl.h:96: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Eric Seidel (no email)
Comment 4 2010-11-05 21:44:42 PDT
Attachment 73163 [details] did not build on mac: Build output: http://queues.webkit.org/results/5302025
Simon Fraser (smfr)
Comment 5 2010-11-05 21:56:19 PDT
http://trac.webkit.org/changeset/71462
Simon Fraser (smfr)
Comment 6 2010-11-05 22:35:10 PDT
I backed this out because of weird linker errors.
Eric Seidel (no email)
Comment 8 2010-12-14 01:45:44 PST
Curious what the status here is.
Simon Fraser (smfr)
Comment 9 2010-12-14 08:32:13 PST
Replace DeprecatedListPtr use for floats with a <vector> or something else.
Eric Seidel (no email)
Comment 10 2010-12-20 22:56:03 PST
r71462. Please close bugs after landing. webkit-patch land will do this automatically for you. :)
Simon Fraser (smfr)
Comment 11 2010-12-20 22:58:42 PST
The patch was backed out because of linker issues.
Note You need to log in before you can comment on or make changes to this bug.