Bug 49119 – Add AudioNode custom bindings

• Component: New Bugs
• Status: RESOLVED FIXED

[Chris Rogers]

Add AudioNode custom bindings

[Chris Rogers]

Created attachment 73151 [details]
Patch

[Chris Rogers]

Created attachment 73152 [details]
Patch

[Kenneth Russell]

Comment on attachment 73152 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=73152&action=review

Basically looks fine; r- for unnecessary checks.

> WebCore/bindings/js/JSAudioNodeCustom.cpp:42
> +    if (exec->argumentCount() > 3)
> +        return throwError(exec, createSyntaxError(exec, "Too many arguments"));

It isn't an error to pass too many arguments to a JavaScript function.

> WebCore/bindings/js/JSAudioNodeCustom.cpp:68
> +    if (exec->argumentCount() > 1)
> +        return throwError(exec, createSyntaxError(exec, "Too many arguments"));

Unnecessary check per above.

> WebCore/bindings/v8/custom/V8AudioNodeCustom.cpp:45
> +    if (args.Length() > 3)
> +        return throwError("Too many arguments", V8Proxy::SyntaxError);

Unnecessary check per above.

> WebCore/bindings/v8/custom/V8AudioNodeCustom.cpp:77
> +    if (args.Length() > 1)
> +        return throwError("Too many arguments", V8Proxy::SyntaxError);

Unnecessary check per above.

[Chris Rogers]

Created attachment 73671 [details]
Patch

[Chris Rogers]

Comment on attachment 73152 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=73152&action=review

>> WebCore/bindings/js/JSAudioNodeCustom.cpp:42
>> +        return throwError(exec, createSyntaxError(exec, "Too many arguments"));
> 
> It isn't an error to pass too many arguments to a JavaScript function.

FIXED

>> WebCore/bindings/js/JSAudioNodeCustom.cpp:68
>> +        return throwError(exec, createSyntaxError(exec, "Too many arguments"));
> 
> Unnecessary check per above.

FIXED

>> WebCore/bindings/v8/custom/V8AudioNodeCustom.cpp:45
>> +        return throwError("Too many arguments", V8Proxy::SyntaxError);
> 
> Unnecessary check per above.

FIXED

>> WebCore/bindings/v8/custom/V8AudioNodeCustom.cpp:77
>> +        return throwError("Too many arguments", V8Proxy::SyntaxError);
> 
> Unnecessary check per above.

FIXED

[Kenneth Russell]

Comment on attachment 73671 [details]
Patch

Looks good to me.

[WebKit Commit Bot]

Comment on attachment 73671 [details]
Patch

Rejecting patch 73671 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive']" exit_code: 2
Last 500 characters of output:
do ...............................
editing/unsupported-content .........
fast/backgrounds ..........................
fast/backgrounds/repeat .......
fast/backgrounds/size ..........................
fast/block/basic ...............................
fast/block/float ...............
fast/block/float/015.html -> failed

Exiting early after 1 failures. 5611 tests run.
97.38s total testing time

5610 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
3 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/6051078

[Chris Rogers]

putting back in commit queue.  It previously failed on a completely unrelated test.

[WebKit Commit Bot]

Comment on attachment 73671 [details]
Patch

Clearing flags on attachment: 73671

Committed r72057: <http://trac.webkit.org/changeset/72057>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.