Bug 49114

Summary: [Qt] make install does not cause JavaScriptCore to be built
Product: WebKit Reporter: Sam Magnuson <smagnuso>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch
none
patch none

Sam Magnuson
Reported 2010-11-05 16:52:58 PDT
When I do a make install at the root directory it will not build JavaScriptCore if there are changes (because libjs is just a .a). I've added an install target just so it will get compiled on a make install.
Attachments
patch (1.10 KB, patch)
2010-11-05 17:02 PDT, Sam Magnuson 		no flags
DetailsFormatted DiffDiff
patch (1.09 KB, patch)
2010-11-05 17:03 PDT, Sam Magnuson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Magnuson
Comment 1 2010-11-05 17:02:24 PDT
Created attachment 73145 [details] patch
Sam Magnuson
Comment 2 2010-11-05 17:03:45 PDT
Created attachment 73146 [details] patch Remove extraneous / in changelog.
Andreas Kling
Comment 3 2010-11-07 19:07:21 PST
Comment on attachment 73146 [details] patch LGTM. This has itched me on occasion, thanks for the fix!
Andreas Kling
Comment 4 2010-11-07 19:08:56 PST
Comment on attachment 73146 [details] patch Clearing flags on attachment: 73146 Committed r71489: <http://trac.webkit.org/changeset/71489>
Andreas Kling
Comment 5 2010-11-07 19:09:05 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.