Bug 49082

Summary: [EFL] Change the usage of eina_iterator_next due to latest EFL changes.
Product: WebKit Reporter: Rafael Antognolli <antognolli+webkit>
Component: WebKit EFLAssignee: Rafael Antognolli <antognolli+webkit>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, kenneth, leandro, lucas.de.marchi, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Rafael Antognolli
Reported 2010-11-05 11:32:57 PDT
[EFL] Change the usage of eina_iterator_next due to latest EFL changes.
Attachments
Patch (2.16 KB, patch)
2010-11-05 11:35 PDT, Rafael Antognolli 		no flags
DetailsFormatted DiffDiff
Patch (2.18 KB, patch)
2010-11-05 11:45 PDT, Rafael Antognolli 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Rafael Antognolli
Comment 1 2010-11-05 11:35:02 PDT
Created attachment 73090 [details] Patch
Antonio Gomes
Comment 2 2010-11-05 11:38:48 PDT
Comment on attachment 73090 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=73090&action=review > WebKit/efl/ChangeLog:8 > + https://bugs.webkit.org/show_bug.cgi?id=49082 > + > + A change on how the iterator for a tiler is used in EFL needs to be Fix indentation, please.
WebKit Review Bot
Comment 3 2010-11-05 11:39:14 PDT
Attachment 73090 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebKit/efl/ChangeLog', u'WebKit/efl/ewk/ewk_view_single.c']" exit_code: 1 WebKit/efl/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] WebKit/efl/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] WebKit/efl/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] WebKit/efl/ChangeLog:11: Line contains tab character. [whitespace/tab] [5] Total errors found: 4 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Rafael Antognolli
Comment 4 2010-11-05 11:45:58 PDT
Created attachment 73094 [details] Patch
Leandro Pereira
Comment 5 2010-11-08 12:57:02 PST
Comment on attachment 73094 [details] Patch I'll land the patch manually, since this'll break the build temporarily. Removing cq+.
Leandro Pereira
Comment 6 2010-11-08 13:00:51 PST
Comment on attachment 73094 [details] Patch Clearing flags on attachment: 73094 Committed r71561: <http://trac.webkit.org/changeset/71561>
Leandro Pereira
Comment 7 2010-11-08 13:01:00 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.