Bug 49078

Summary: [Chromium] fast/events/stopPropagation-submit.html fails
Product: WebKit Reporter: Mihai Parparita <mihaip>
Component: Tools / TestsAssignee: Mihai Parparita <mihaip>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Mihai Parparita
Reported 2010-11-05 10:56:51 PDT
[Chromium] fast/events/stopPropagation-submit.html fails
Attachments
Patch (3.61 KB, patch)
2010-11-05 11:00 PDT, Mihai Parparita 		no flags
DetailsFormatted DiffDiff
Patch (3.70 KB, patch)
2010-11-05 14:05 PDT, Mihai Parparita 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mihai Parparita
Comment 1 2010-11-05 11:00:26 PDT
Created attachment 73084 [details] Patch
Ojan Vafai
Comment 2 2010-11-05 13:25:33 PDT
Comment on attachment 73084 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=73084&action=review > LayoutTests/ChangeLog:16 > + * FWIW, it looks like GURL is right, per step 15 of section 4.10.22.3 > + (Form submission algorithm) of the HTML 5, data URLs used with GET > + should not be mutated. Please file a bug for this. Either KURL should be changed or GURL/HTML5 should be. > LayoutTests/fast/events/stopPropagation-submit.html:3 > see a link below and the text FAIL. On success you will see PASS (and This description doesn't seem to be correct. I don't see anywhere that FAIL would get printed out. Mind fixing that while you're modifying this test?
Mihai Parparita
Comment 3 2010-11-05 14:01:23 PDT
(In reply to comment #2) > (From update of attachment 73084 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=73084&action=review > > > LayoutTests/ChangeLog:16 > > + * FWIW, it looks like GURL is right, per step 15 of section 4.10.22.3 > > + (Form submission algorithm) of the HTML 5, data URLs used with GET > > + should not be mutated. > > Please file a bug for this. Either KURL should be changed or GURL/HTML5 should be. Filed bug bug 49091 about this. > > LayoutTests/fast/events/stopPropagation-submit.html:3 > > see a link below and the text FAIL. On success you will see PASS (and > > This description doesn't seem to be correct. I don't see anywhere that FAIL would get printed out. Mind fixing that while you're modifying this test? FAIL is included at line 10, if the test fails (and stopPropagation prevents form submission) then the original page's text will be dumped. Will upload a new patch anyway so that there's a reference to bug 49091 in the ChangeLog.
Mihai Parparita
Comment 4 2010-11-05 14:05:16 PDT
Created attachment 73114 [details] Patch
Ojan Vafai
Comment 5 2010-11-05 14:20:11 PDT
Comment on attachment 73114 [details] Patch Oh, sorry, I missed the FAIL line.
WebKit Commit Bot
Comment 6 2010-11-05 14:41:36 PDT
Comment on attachment 73114 [details] Patch Clearing flags on attachment: 73114 Committed r71450: <http://trac.webkit.org/changeset/71450>
WebKit Commit Bot
Comment 7 2010-11-05 14:41:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.