Bug 49076

Summary: loadedPlugins parameter to PluginInfoStore::shouldUsePlugin is redundant
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: New BugsAssignee: Adam Roben (:aroben) <aroben>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, eric, jhoneycutt
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 43509    
Attachments:
Description Flags
Patch andersca: review+

Adam Roben (:aroben)
Reported 2010-11-05 10:41:12 PDT
loadedPlugins parameter to PluginInfoStore::shouldUsePlugin is redundant
Attachments
Patch (5.85 KB, patch)
2010-11-05 10:43 PDT, Adam Roben (:aroben) 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2010-11-05 10:43:02 PDT
Created attachment 73081 [details] Patch
Adam Roben (:aroben)
Comment 2 2010-11-05 10:47:17 PDT
Comment on attachment 73081 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=73081&action=review > WebKit2/UIProcess/Plugins/PluginInfoStore.h:82 > - static bool shouldUsePlugin(const Plugin& plugin, const Vector<Plugin>& loadedPlugins); > + static bool shouldUsePlugin(const Plugin& plugin); Whoops, that "static" should have been removed.
Eric Seidel (no email)
Comment 3 2010-11-05 10:50:23 PDT
Attachment 73081 [details] did not build on mac: Build output: http://queues.webkit.org/results/5255012
Adam Roben (:aroben)
Comment 4 2010-11-05 11:16:10 PDT
Committed r71435: <http://trac.webkit.org/changeset/71435>
Note You need to log in before you can comment on or make changes to this bug.