Bug 49076 - loadedPlugins parameter to PluginInfoStore::shouldUsePlugin is redundant
Summary: loadedPlugins parameter to PluginInfoStore::shouldUsePlugin is redundant
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords:
Depends on:
Blocks: 43509
  Show dependency tree / graph
 
Reported: 2010-11-05 10:41 PDT by Adam Roben (:aroben)
Modified: 2010-11-05 11:16 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.85 KB, patch)
2010-11-05 10:43 PDT, Adam Roben (:aroben) 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2010-11-05 10:41:12 PDT 
loadedPlugins parameter to PluginInfoStore::shouldUsePlugin is redundant
Comment 1 Adam Roben (:aroben) 2010-11-05 10:43:02 PDT 
Created attachment 73081 [details]
Patch
Comment 2 Adam Roben (:aroben) 2010-11-05 10:47:17 PDT 
Comment on attachment 73081 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=73081&action=review

> WebKit2/UIProcess/Plugins/PluginInfoStore.h:82
> -    static bool shouldUsePlugin(const Plugin& plugin, const Vector<Plugin>& loadedPlugins);
> +    static bool shouldUsePlugin(const Plugin& plugin);

Whoops, that "static" should have been removed.
Comment 3 Eric Seidel (no email) 2010-11-05 10:50:23 PDT 
Attachment 73081 [details] did not build on mac:
Build output: http://queues.webkit.org/results/5255012
Comment 4 Adam Roben (:aroben) 2010-11-05 11:16:10 PDT 
Committed r71435: <http://trac.webkit.org/changeset/71435>