Bug 49049

Summary:

Could review tool include style failure info?

Product:

WebKit

Reporter:

Oliver Hunt <oliver>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, ojan

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	oliver: review+

Oliver Hunt

Reported 2010-11-04 20:38:49 PDT

I was just reviewing a patch that made the style bot go red for bogus reasons, it was annoying to have to go away and look at a separate page to identify whether the errors were indeed correct. It would be awesome if the style failures could be displayed inline in the review tool

Attachments
Patch (2.74 KB, patch) 2011-01-20 16:48 PST, Ojan Vafai	oliver: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2010-11-04 20:40:12 PDT

Woh, crazy talk. Should be quite easy to do, I think.

Adam Barth

Comment 2 2010-11-05 10:20:28 PDT

Yeah, I was planning to do this originally, but never got around to it. We just need to write a parser for the style queue output, which shouldn't be that hard.

Ojan Vafai

Comment 3 2011-01-20 16:48:41 PST

Created attachment 79666 [details] Patch

Ojan Vafai

Comment 4 2011-01-20 16:59:04 PST

Committed r76310: <http://trac.webkit.org/changeset/76310>

Note You need to log in before you can comment on or make changes to this bug.