Bug 49046

Summary: Implement NP_RemoveProperty and NP_Enumerate
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch oliver: review+

Anders Carlsson
Reported 2010-11-04 18:47:45 PDT
Implement NP_RemoveProperty and NP_Enumerate
Attachments
Patch (9.30 KB, patch)
2010-11-04 18:51 PDT, Anders Carlsson 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2010-11-04 18:51:29 PDT
Created attachment 73028 [details] Patch
WebKit Review Bot
Comment 2 2010-11-04 18:53:39 PDT
Attachment 73028 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/mac-wk2/Skipped', u'WebKit2/ChangeLog', u'WebKit2/Shared/Plugins/NPObjectMessageReceiver.cpp', u'WebKit2/Shared/Plugins/NPObjectMessageReceiver.h', u'WebKit2/Shared/Plugins/NPObjectMessageReceiver.messages.in', u'WebKit2/Shared/Plugins/NPObjectProxy.cpp', u'WebKit2/Shared/Plugins/NPObjectProxy.h']" exit_code: 1 WebKit2/Shared/Plugins/NPObjectProxy.cpp:281: NPObjectProxy::NP_RemoveProperty is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/Shared/Plugins/NPObjectProxy.cpp:286: NPObjectProxy::NP_Enumerate is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Oliver Hunt
Comment 3 2010-11-04 20:35:58 PDT
Comment on attachment 73028 [details] Patch r=me
Anders Carlsson
Comment 4 2010-11-05 10:40:44 PDT
Committed r71430: <http://trac.webkit.org/changeset/71430>
Note You need to log in before you can comment on or make changes to this bug.