Bug 49044

Summary: cleanup style in TestNetscapePlugIn/PluginObject.cpp
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, dglazkov, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Tony Chang
Reported 2010-11-04 18:15:48 PDT
cleanup style in TestNetscapePlugIn/PluginTest.cpp
Attachments
Patch (14.20 KB, patch)
2010-11-04 18:16 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch (19.91 KB, patch)
2010-11-05 09:53 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2010-11-04 18:16:58 PDT
Created attachment 73022 [details] Patch
Tony Chang
Comment 2 2010-11-04 18:17:48 PDT
Mostly just converting "else if" with early returns into separate "if" statements.
Kent Tamura
Comment 3 2010-11-04 18:48:44 PDT
Comment on attachment 73022 [details] Patch check-webkit-style shows other errors for PluginObject.cpp. Would you like to fix them too?
Tony Chang
Comment 4 2010-11-05 09:53:35 PDT
Created attachment 73073 [details] Patch
Tony Chang
Comment 5 2010-11-05 09:54:27 PDT
Comment on attachment 73073 [details] Patch The only remaining error is about config.h, which doesn't apply here.
WebKit Commit Bot
Comment 6 2010-11-05 12:37:57 PDT
Comment on attachment 73073 [details] Patch Clearing flags on attachment: 73073 Committed r71443: <http://trac.webkit.org/changeset/71443>
WebKit Commit Bot
Comment 7 2010-11-05 12:38:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.