Bug 49017

Summary: Title for images should use localized numerals
Product: WebKit Reporter: Mike Thole <mthole>
Component: PlatformAssignee: Mike Thole <mthole>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.6   
Attachments:
Description Flags
Proposed patch mitz: review+

Mike Thole
Reported 2010-11-04 12:50:33 PDT
The page title displayed when viewing an image (e.g. "MyImage.jpg 20x20 pixels") should use localized numerals.
Attachments
Proposed patch (9.81 KB, patch)
2010-11-04 12:52 PDT, Mike Thole 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mike Thole
Comment 1 2010-11-04 12:52:14 PDT
Created attachment 72973 [details] Proposed patch
mitz
Comment 2 2010-11-04 13:01:15 PDT
Comment on attachment 72973 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=72973&action=review > WebKit/mac/WebCoreSupport/WebPlatformStrategies.mm:666 > + return [NSString localizedStringWithFormat:UI_STRING("%@ %@Ã%@ pixels", "window title for a standalone image (uses multiplication symbol, not x)"), (NSString *)filename, widthString, heightString]; Perhaps the localizer comment should mention that the first argument is a filename (the may be helpful to localizers trying to decide what bidi embedding characters to use and where).
Mike Thole
Comment 3 2010-11-04 13:04:27 PDT
Committed revision 71353.
Note You need to log in before you can comment on or make changes to this bug.