| Summary: | Enable running of Qt API tests on BuildBot | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Gabor Rapcsanyi <rgabor> | ||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abecsi, ossy, wsiegrist | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Gabor Rapcsanyi
2010-11-04 09:23:19 PDT
Created attachment 72949 [details] proposed patch It's running now on our x86 bots at http://webkit.sed.hu/buildbot/waterfall with this config. Comment on attachment 72949 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=72949&action=review Otherwise LGTM, r=me with these changes. Bill, could you execute a reconfigure on buildbot master after this patch landed? > WebKitTools/BuildSlaveSupport/build.webkit.org-config/master.cfg:337 > + def evaluateCommand(self, cmd): > + if self.incorrectLines: > + return FAILURE Qt API tests are quite stable, but I think we shouldn't block the bots if it fails. I prefer using WARNINGS instead of FAILURE. > WebKitTools/BuildSlaveSupport/build.webkit.org-config/master.cfg:342 > + if cmd.rc != 0: > + return FAILURE > + > + return SUCCESS Ditto. Landed in http://trac.webkit.org/changeset/71509 Bill, could you reconfigure the buildbot master, please? Master restart started. (In reply to comment #4) > Master restart started. Thx, it works now. ;) |