Bug 49004

Summary: Enable running of Qt API tests on BuildBot
Product: WebKit Reporter: Gabor Rapcsanyi <rgabor>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, ossy, wsiegrist
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
proposed patch none

Gabor Rapcsanyi
Reported 2010-11-04 09:23:19 PDT
Run Qt API tests on Qt slaves.
Attachments
proposed patch (2.86 KB, patch)
2010-11-04 09:34 PDT, Gabor Rapcsanyi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gabor Rapcsanyi
Comment 1 2010-11-04 09:34:06 PDT
Created attachment 72949 [details] proposed patch It's running now on our x86 bots at http://webkit.sed.hu/buildbot/waterfall with this config.
Csaba Osztrogonác
Comment 2 2010-11-05 15:51:43 PDT
Comment on attachment 72949 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=72949&action=review Otherwise LGTM, r=me with these changes. Bill, could you execute a reconfigure on buildbot master after this patch landed? > WebKitTools/BuildSlaveSupport/build.webkit.org-config/master.cfg:337 > + def evaluateCommand(self, cmd): > + if self.incorrectLines: > + return FAILURE Qt API tests are quite stable, but I think we shouldn't block the bots if it fails. I prefer using WARNINGS instead of FAILURE. > WebKitTools/BuildSlaveSupport/build.webkit.org-config/master.cfg:342 > + if cmd.rc != 0: > + return FAILURE > + > + return SUCCESS Ditto.
Csaba Osztrogonác
Comment 3 2010-11-08 04:11:55 PST
Landed in http://trac.webkit.org/changeset/71509 Bill, could you reconfigure the buildbot master, please?
William Siegrist
Comment 4 2010-11-08 08:40:51 PST
Master restart started.
Csaba Osztrogonác
Comment 5 2010-11-09 07:19:32 PST
(In reply to comment #4) > Master restart started. Thx, it works now. ;)
Note You need to log in before you can comment on or make changes to this bug.