Bug 48974

Summary: Use leakRef instead of releaseRef
Product: WebKit Reporter: Xan Lopez <xan.lopez>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
leakref.diff none

Xan Lopez
Reported 2010-11-03 21:39:18 PDT
SSIA.
Attachments
leakref.diff (15.38 KB, patch)
2010-11-03 21:44 PDT, Xan Lopez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Xan Lopez
Comment 1 2010-11-03 21:44:32 PDT
Created attachment 72903 [details] leakref.diff
Adam Barth
Comment 2 2010-11-04 14:07:21 PDT
Comment on attachment 72903 [details] leakref.diff Can you add more information to the ChangeLog as to why?
Xan Lopez
Comment 3 2010-11-04 14:56:10 PDT
(In reply to comment #2) > (From update of attachment 72903 [details]) > Can you add more information to the ChangeLog as to why? Like explain why it's deprecated or?
Xan Lopez
Comment 4 2010-11-04 18:17:41 PDT
Comment on attachment 72903 [details] leakref.diff Ok, I added an extra sentence explaining why the rename happened in the first place, hope that's enough. FWIW, the rename wasn't explained in the commit where leakRef happened (reviewed by a "Adam Barth" ;)), so I just went to the original mailing list thread.
Xan Lopez
Comment 5 2010-11-04 18:17:58 PDT
Closing bug.
Note You need to log in before you can comment on or make changes to this bug.