Bug 48958

Summary:

[Qt] DRT sideeffect revealed by r71268

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, commit-queue, webkit.review.bot

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
proposed fix	none
proposed fix	none

Csaba Osztrogonác

Reported 2010-11-03 15:23:23 PDT

After r71268, 15 tests fail on Qt bot: http://build.webkit.org/results/Qt%20Linux%20Release/r71268%20%2823109%29/results.html r71268 fixed an absolutely unrelated bug, and unskipped two tests: canvas/philip/tests/2d.pattern.image.null.html canvas/philip/tests/2d.pattern.image.undefined.html old-run-webkit-test script restarts DRT after 1000 tests, and this patch shifted the restart point, and the bug was revealed.

Attachments
proposed fix (3.26 KB, patch) 2011-05-02 06:01 PDT, Fehér Zsolt	no flags	Details Formatted Diff Diff
proposed fix (3.26 KB, patch) 2011-05-02 06:11 PDT, Fehér Zsolt	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Csaba Osztrogonác

Comment 1 2010-11-03 15:50:58 PDT

I added the unskipped tests to the Skipped list again, to make builbot happy: canvas/philip/tests/2d.pattern.image.null.html canvas/philip/tests/2d.pattern.image.undefined.html http://trac.webkit.org/changeset/71276 Tomorrow I'm going to find a real fix for this bug.

Csaba Osztrogonác

Comment 2 2010-11-03 18:45:39 PDT

Unfortunately 3 new tests added in http://trac.webkit.org/changeset/71277 , and the 15 tests fail again. I found the real culprit: svg/custom/text-zoom.xhtml , and skipped it by http://trac.webkit.org/changeset/71295

Fehér Zsolt

Comment 3 2011-05-02 06:01:52 PDT

Created attachment 91917 [details] proposed fix

WebKit Review Bot

Comment 4 2011-05-02 06:04:39 PDT

Attachment 91917 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:557: Should have a space between // and comment [whitespace/comments] [4] Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:558: Should have a space between // and comment [whitespace/comments] [4] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.

Fehér Zsolt

Comment 5 2011-05-02 06:11:00 PDT

Created attachment 91920 [details] proposed fix

Csaba Osztrogonác

Comment 6 2011-05-02 07:07:49 PDT

Comment on attachment 91920 [details] proposed fix r=me

WebKit Commit Bot

Comment 7 2011-05-02 07:27:41 PDT

Comment on attachment 91920 [details] proposed fix Clearing flags on attachment: 91920 Committed r85474: <http://trac.webkit.org/changeset/85474>

WebKit Commit Bot

Comment 8 2011-05-02 07:27:46 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.