Summary: | [Qt] DRT sideeffect revealed by r71268 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | benjamin, commit-queue, webkit.review.bot | ||||||
Priority: | P2 | Keywords: | Qt, QtTriaged | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Csaba Osztrogonác
2010-11-03 15:23:23 PDT
I added the unskipped tests to the Skipped list again, to make builbot happy: canvas/philip/tests/2d.pattern.image.null.html canvas/philip/tests/2d.pattern.image.undefined.html http://trac.webkit.org/changeset/71276 Tomorrow I'm going to find a real fix for this bug. Unfortunately 3 new tests added in http://trac.webkit.org/changeset/71277 , and the 15 tests fail again. I found the real culprit: svg/custom/text-zoom.xhtml , and skipped it by http://trac.webkit.org/changeset/71295 Created attachment 91917 [details]
proposed fix
Attachment 91917 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:557: Should have a space between // and comment [whitespace/comments] [4]
Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:558: Should have a space between // and comment [whitespace/comments] [4]
Total errors found: 2 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 91920 [details]
proposed fix
Comment on attachment 91920 [details]
proposed fix
r=me
Comment on attachment 91920 [details] proposed fix Clearing flags on attachment: 91920 Committed r85474: <http://trac.webkit.org/changeset/85474> All reviewed patches have been landed. Closing bug. |