Summary: | [Web Timing] Rename interfaces | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tony Gentilcore <tonyg> | ||||||||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | abarth, commit-queue, dglazkov, fishd, gustavo, simonjam, webkit-ews, webkit.review.bot, xan.lopez | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | All | ||||||||||||||
OS: | All | ||||||||||||||
Bug Depends on: | |||||||||||||||
Bug Blocks: | 30685, 48922 | ||||||||||||||
Attachments: |
|
Description
Tony Gentilcore
2010-11-03 09:23:31 PDT
Created attachment 73288 [details]
Patch
This looks correct to me. Dimitri might be able to r+. Attachment 73288 [details] did not build on gtk: Build output: http://queues.webkit.org/results/5559041 Attachment 73288 [details] did not build on qt: Build output: http://queues.webkit.org/results/5548035 Created attachment 73293 [details]
Patch
Manually created patch. webkit-patch ignored the renamed files.
Attachment 73293 [details] did not build on qt: Build output: http://queues.webkit.org/results/5529040 Created attachment 73299 [details]
Patch
Created attachment 73448 [details]
Patch
Merged with other WebTiming changes from yesterday.
I think this is ready to go in. I fixed the issues with Qt and GTK and they're both green now.
Created attachment 73677 [details]
Patch
Updated for EFL and Android.
This has an LGTM. Can I get an R+? Thanks. Comment on attachment 73677 [details] Patch Clearing flags on attachment: 73677 Committed r71951: <http://trac.webkit.org/changeset/71951> All reviewed patches have been landed. Closing bug. |