Bug 48898

Summary: Convert SVGAnimatedString/SVGStringList to the new SVG*PropertyTearOff concept
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: mdelaney7, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 40887, 47905    
Attachments:
Description Flags
Patch krit: review+

Nikolas Zimmermann
Reported 2010-11-03 00:38:21 PDT
Convert SVGAnimatedString/SVGStringList to the new SVG*PropertyTearOff concept. Soon we're done with these changes! Once this is done the bug 40887 "requiredFeatures does not adapt to SVGStringList changes" can be fixed in a proper way, w/o the need to add custom list code for JSC/V8.
Attachments
Patch (103.61 KB, patch)
2010-11-03 02:47 PDT, Nikolas Zimmermann 		krit: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2010-11-03 02:47:13 PDT
Created attachment 72804 [details] Patch
Dirk Schulze
Comment 2 2010-11-03 04:08:33 PDT
Comment on attachment 72804 [details] Patch Looks great. r=me
Nikolas Zimmermann
Comment 3 2010-11-03 04:15:07 PDT
Landed in r71227. Unfortunately EWS is not checking this patch, nor any other patch today, so I'm praying it works on all platforms, let's see. Closing the bug, after I got results.
Nikolas Zimmermann
Comment 4 2010-11-03 04:23:25 PDT
Landed chromium/v8 build fix in r71229.
Nikolas Zimmermann
Comment 5 2010-11-03 04:34:15 PDT
Landed next chromium/v8 build fix in r71230.
Nikolas Zimmermann
Comment 6 2010-11-03 05:15:49 PDT
Ok, I gave up and tried a local chromium ToT build. Now CodeGeneratorV8 is fixed... Landed final fix in r71232.
Note You need to log in before you can comment on or make changes to this bug.