| Summary: | [Qt] Adding iphone user agent string the user agent list for QtTestBrowser | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Leonid Ebril <leonid.ebril> | ||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ademar, commit-queue, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Leonid Ebril
2010-11-02 14:01:51 PDT
Created attachment 72749 [details]
adding user agent string for iphone 4 to the useragentlist.txt
added user agent string for iphone 4
Attachment 72749 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebKitTools/ChangeLog', u'WebKitTools/QtTestBrowser/useragentlist.txt']" exit_code: 1
WebKitTools/QtTestBrowser/useragentlist.txt:1: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
Total errors found: 10 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 72749 [details]
adding user agent string for iphone 4 to the useragentlist.txt
The change is fine, but the patch should be using Unix newlines, rather than CRLF.
Created attachment 72816 [details]
an updated version of patch (using Unix newlines, rather than CRLF).
Comment on attachment 72816 [details]
an updated version of patch (using Unix newlines, rather than CRLF).
r=me
Comment on attachment 72816 [details] an updated version of patch (using Unix newlines, rather than CRLF). Clearing flags on attachment: 72816 Committed r71325: <http://trac.webkit.org/changeset/71325> All reviewed patches have been landed. Closing bug. Revision r71325 cherry-picked into qtwebkit-2.2 with commit 7a3db1d <http://gitorious.org/webkit/qtwebkit/commit/7a3db1d> Has just been cherry-picked to qtwebkit-2.2, removing blockage. |