Bug 48864

Summary: Add some support for remote and local NPObjects to NPRemoteObjectMap
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch aroben: review+

Description Anders Carlsson 2010-11-02 13:09:28 PDT 
Add some support for remote and local NPObjects to NPRemoteObjectMap
Comment 1 Anders Carlsson 2010-11-02 13:13:08 PDT 
Created attachment 72724 [details]
Patch
Comment 2 Adam Roben (:aroben) 2010-11-02 13:17:08 PDT 
Comment on attachment 72724 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72724&action=review

> WebKit2/Shared/Plugins/NPVariantData.cpp:109
> +    // We special case LocalNPObjectID and RemoteNPObjectID here so a LocalNPObjectID is
> +    // encoded as a RemoteNPObjectID and vice versa.

Should be "special-case" and "decoded", not "special case" and "encoded". Maybe you could explain a little more, saying that the encoded type is from the perspective of the other process, so we have to adjust it to match our own perspective?
Comment 3 Anders Carlsson 2010-11-02 13:26:06 PDT 
Committed r71156: <http://trac.webkit.org/changeset/71156>