Bug 48844

Summary: Make RenderStyle::playState() return typed value and cleanup naming in Animation code"
Product: WebKit Reporter: Chris Marrin <cmarrin>
Component: New BugsAssignee: Chris Marrin <cmarrin>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch aroben: review+

Chris Marrin
Reported 2010-11-02 09:46:34 PDT
Make RenderStyle::playState() return typed value and cleanup naming in Animation code"
Attachments
Patch (10.28 KB, patch)
2010-11-02 09:51 PDT, Chris Marrin 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Marrin
Comment 1 2010-11-02 09:51:39 PDT
Created attachment 72689 [details] Patch
Adam Roben (:aroben)
Comment 2 2010-11-02 09:56:39 PDT
Comment on attachment 72689 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=72689&action=review > WebCore/page/animation/CompositeAnimation.h:102 > - bool m_isSuspended; > + bool m_suspended; I think this is a step in the wrong direction, but I guess consistency is a good thing. > WebCore/platform/animation/Animation.h:137 > - unsigned m_playState : 2; > + EAnimPlayState m_playState : 2; You need to keep this an unsigned bitfield. Enum bitfields are signed under MSVC, and that will screw up comparison operations. You should cast to EAnimPlayState in the getter.
Chris Marrin
Comment 3 2010-11-02 10:21:14 PDT
Made change suggested by Adam and landed in http://trac.webkit.org/changeset/71125
Note You need to log in before you can comment on or make changes to this bug.