Bug 48841

Summary: Remove special handling of HashTableDeletedValue in PlatformRefPtr and manually manage memory that cannot be controlled by HashTraits
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch for this issue xan.lopez: review+

Martin Robinson
Reported 2010-11-02 08:55:40 PDT
https://bugs.webkit.org/show_bug.cgi?id=46794 introduced handling of HashTableDeletedValue into the smart point directly. This was incorrect. Instead, in places where class members track whether or not their parent has been deleted from a hash table, use manual memory management for those members.
Attachments
Patch for this issue (14.25 KB, patch)
2010-11-02 11:45 PDT, Martin Robinson 		xan.lopez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2010-11-02 11:45:06 PDT
Created attachment 72707 [details] Patch for this issue
Xan Lopez
Comment 2 2010-11-02 11:56:48 PDT
Comment on attachment 72707 [details] Patch for this issue Makes sense.
Martin Robinson
Comment 3 2010-11-02 12:20:57 PDT
Committed r71148: <http://trac.webkit.org/changeset/71148>
Note You need to log in before you can comment on or make changes to this bug.