Bug 48835

Summary: Unused class: JSFastMath with JSValue64
Product: WebKit Reporter: Gabor Loki <loki>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Trivial CC: barraclough, commit-queue, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: All   
Attachments:
Description Flags
remove JSFastMath class none

Gabor Loki
Reported 2010-11-02 07:08:13 PDT
There is an unused class in JSImmediate.h: JSFastMath. It can be safely removed.
Attachments
remove JSFastMath class (5.88 KB, patch)
2010-11-02 07:11 PDT, Gabor Loki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gabor Loki
Comment 1 2010-11-02 07:11:26 PDT
Created attachment 72661 [details] remove JSFastMath class
Geoffrey Garen
Comment 2 2010-11-02 08:02:04 PDT
Comment on attachment 72661 [details] remove JSFastMath class r=me
WebKit Commit Bot
Comment 3 2010-11-02 15:28:44 PDT
Comment on attachment 72661 [details] remove JSFastMath class Rejecting patch 72661 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive']" exit_code: 2 Last 500 characters of output: ..... fast/tokenizer ........................................ fast/transforms ....................... fast/url .................... fast/workers ............................................. fast/workers/storage .......................... fast/workers/storage/use-same-database-in-page-and-workers.html -> failed Exiting early after 1 failures. 16101 tests run. 502.96s total testing time 16100 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 5 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/4930021
Gabor Loki
Comment 4 2010-11-03 00:24:07 PDT
Comment on attachment 72661 [details] remove JSFastMath class It should be a flaky test, works here. CQ, try again!
WebKit Commit Bot
Comment 5 2010-11-03 01:22:19 PDT
Comment on attachment 72661 [details] remove JSFastMath class Clearing flags on attachment: 72661 Committed r71220: <http://trac.webkit.org/changeset/71220>
WebKit Commit Bot
Comment 6 2010-11-03 01:22:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.