Bug 48816

Summary: [GTK] PopupMenuGtk has a very confusing if-else block
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Code cleanup dbates: review+

Martin Robinson
Reported 2010-11-01 18:31:13 PDT
There is some very confusing code in PopupMenuGtk. This bug tracks cleaning it up.
Attachments
Code cleanup (2.02 KB, patch)
2010-11-01 18:34 PDT, Martin Robinson 		dbates: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2010-11-01 18:34:17 PDT
Created attachment 72615 [details] Code cleanup
Daniel Bates
Comment 2 2010-11-01 18:35:32 PDT
Comment on attachment 72615 [details] Code cleanup Looks good to me. Yay! for the cleanup. r=me
Martin Robinson
Comment 3 2010-11-01 18:46:14 PDT
Comment on attachment 72615 [details] Code cleanup Removing this from the commit-queue since dbates warned me that it could land uncleanly.
Martin Robinson
Comment 4 2010-11-01 21:34:47 PDT
Committed r71099: <http://trac.webkit.org/changeset/71099>
Note You need to log in before you can comment on or make changes to this bug.