Bug 48816 - [GTK] PopupMenuGtk has a very confusing if-else block
Summary: [GTK] PopupMenuGtk has a very confusing if-else block
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-01 18:31 PDT by Martin Robinson
Modified: 2010-11-01 21:34 PDT (History)
1 user (show)

See Also:

Attachments
Code cleanup (2.02 KB, patch)
2010-11-01 18:34 PDT, Martin Robinson 		dbates: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2010-11-01 18:31:13 PDT 
There is some very confusing code in PopupMenuGtk. This bug tracks cleaning it up.
Comment 1 Martin Robinson 2010-11-01 18:34:17 PDT 
Created attachment 72615 [details]
Code cleanup
Comment 2 Daniel Bates 2010-11-01 18:35:32 PDT 
Comment on attachment 72615 [details]
Code cleanup

Looks good to me. Yay! for the cleanup.
r=me
Comment 3 Martin Robinson 2010-11-01 18:46:14 PDT 
Comment on attachment 72615 [details]
Code cleanup

Removing this from the commit-queue since dbates warned me that it could land uncleanly.
Comment 4 Martin Robinson 2010-11-01 21:34:47 PDT 
Committed r71099: <http://trac.webkit.org/changeset/71099>