Bug 48798

Summary: Add RealtimeAnalyserNode files
Product: WebKit Reporter: Chris Rogers <crogers>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, commit-queue, dglazkov, eric.carlson, jamesr, jer.noble, kbr, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Chris Rogers
Reported 2010-11-01 16:18:12 PDT
Add RealtimeAnalyserNode files
Attachments
Patch (11.16 KB, patch)
2010-11-01 16:20 PDT, Chris Rogers 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Rogers
Comment 1 2010-11-01 16:20:41 PDT
Created attachment 72589 [details] Patch
Chris Rogers
Comment 2 2010-11-01 16:23:00 PDT
RealtimeAnalyserNode as described in the web audio specification: http://chromium.googlecode.com/svn/trunk/samples/audio/specification/specification.html#RealtimeAnalyserNode-section
Kenneth Russell
Comment 3 2010-11-01 19:01:38 PDT
Comment on attachment 72589 [details] Patch Looks fine. The hardcoded fetches of input and output 0 in process() and pullInputs() are a little subtle, but I see that they make sense because this node is defined as having one output and one input. Since all of the associated code is self-contained in the .cpp, I don't think it's worth asking for assertions about this fact.
WebKit Commit Bot
Comment 4 2010-11-02 13:53:53 PDT
Comment on attachment 72589 [details] Patch Clearing flags on attachment: 72589 Committed r71163: <http://trac.webkit.org/changeset/71163>
WebKit Commit Bot
Comment 5 2010-11-02 13:54:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.