Bug 48798

Summary:

Add RealtimeAnalyserNode files

Product:

WebKit

Reporter:

Chris Rogers <crogers>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarrin, commit-queue, dglazkov, eric.carlson, jamesr, jer.noble, kbr, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none

Description Chris Rogers 2010-11-01 16:18:12 PDT

Add RealtimeAnalyserNode files

Comment 1 Chris Rogers 2010-11-01 16:20:41 PDT

Created attachment 72589 [details]
Patch

Comment 2 Chris Rogers 2010-11-01 16:23:00 PDT

RealtimeAnalyserNode as described in the web audio specification:
http://chromium.googlecode.com/svn/trunk/samples/audio/specification/specification.html#RealtimeAnalyserNode-section

Comment 3 Kenneth Russell 2010-11-01 19:01:38 PDT

Comment on attachment 72589 [details]
Patch

Looks fine. The hardcoded fetches of input and output 0 in process() and pullInputs() are a little subtle, but I see that they make sense because this node is defined as having one output and one input. Since all of the associated code is self-contained in the .cpp, I don't think it's worth asking for assertions about this fact.

Comment 4 WebKit Commit Bot 2010-11-02 13:53:53 PDT

Comment on attachment 72589 [details]
Patch

Clearing flags on attachment: 72589

Committed r71163: <http://trac.webkit.org/changeset/71163>

Comment 5 WebKit Commit Bot 2010-11-02 13:54:01 PDT

All reviewed patches have been landed.  Closing bug.