Bug 48798 - Add RealtimeAnalyserNode files
Summary: Add RealtimeAnalyserNode files
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-11-01 16:18 PDT by Chris Rogers
Modified: 2010-11-02 13:54 PDT (History)
8 users (show)

See Also:

Patch (11.16 KB, patch)
2010-11-01 16:20 PDT, Chris Rogers
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2010-11-01 16:18:12 PDT
Add RealtimeAnalyserNode files
Comment 1 Chris Rogers 2010-11-01 16:20:41 PDT
Created attachment 72589 [details]
Comment 2 Chris Rogers 2010-11-01 16:23:00 PDT
RealtimeAnalyserNode as described in the web audio specification:
Comment 3 Kenneth Russell 2010-11-01 19:01:38 PDT
Comment on attachment 72589 [details]

Looks fine. The hardcoded fetches of input and output 0 in process() and pullInputs() are a little subtle, but I see that they make sense because this node is defined as having one output and one input. Since all of the associated code is self-contained in the .cpp, I don't think it's worth asking for assertions about this fact.
Comment 4 WebKit Commit Bot 2010-11-02 13:53:53 PDT
Comment on attachment 72589 [details]

Clearing flags on attachment: 72589

Committed r71163: <http://trac.webkit.org/changeset/71163>
Comment 5 WebKit Commit Bot 2010-11-02 13:54:01 PDT
All reviewed patches have been landed.  Closing bug.