Bug 48786

Summary:

Querying selection start and end should be const

Product:

WebKit

Reporter:

Ilya Sherman <isherman>

Component:

New Bugs

Assignee:

Ilya Sherman <isherman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, darin, dglazkov, eric, isherman, jamesr, simon.fraser, tkent, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	none

Ilya Sherman

Reported 2010-11-01 14:41:40 PDT

Querying selection start and end should be const

Attachments
Patch (2.14 KB, patch) 2010-11-01 14:46 PDT, Ilya Sherman	no flags	Details Formatted Diff Diff
Patch (5.89 KB, patch) 2010-11-05 14:21 PDT, Ilya Sherman	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ilya Sherman

Comment 1 2010-11-01 14:46:29 PDT

Created attachment 72565 [details] Patch

WebKit Commit Bot

Comment 2 2010-11-02 12:37:18 PDT

Comment on attachment 72565 [details] Patch Clearing flags on attachment: 72565 Committed r71150: <http://trac.webkit.org/changeset/71150>

WebKit Commit Bot

Comment 3 2010-11-02 12:37:24 PDT

All reviewed patches have been landed. Closing bug.

WebKit Review Bot

Comment 4 2010-11-02 13:32:22 PDT

http://trac.webkit.org/changeset/71150 might have broken GTK Linux 64-bit Debug The following tests are not passing: canvas/philip/tests/toDataURL.jpeg.primarycolours.html fast/backgrounds/background-repeat-computed-style.html fast/backgrounds/size/backgroundSize17.html fast/backgrounds/size/backgroundSize18.html fast/backgrounds/size/backgroundSize19.html fast/backgrounds/size/contain-and-cover.html fast/blockflow/background-horizontal-bt.html fast/blockflow/background-vertical-lr.html fast/blockflow/background-vertical-rl.html fast/canvas/toDataURL-supportedTypes.html fast/dom/HTMLImageElement/image-load-cross-document.html fast/dom/HTMLImageElement/image-loading-gc.html fast/dom/HTMLImageElement/image-natural-width-height.html fast/dom/HTMLLinkElement/onload-completion-test.html fast/dom/beforeload/image-before-load-innerHTML.html fast/dom/beforeload/image-before-load.html fast/dom/beforeload/image-object-before-load-innerHTML.html fast/dom/beforeload/image-object-before-load.html fast/dom/beforeload/remove-image-in-beforeload-listener.html fast/dom/inner-text-001.html

Ilya Sherman

Comment 5 2010-11-05 14:21:39 PDT

Created attachment 73117 [details] Patch

Ilya Sherman

Comment 6 2010-11-05 14:22:57 PDT

Missed a couple of places with the first patch, including the one that had motivated the patch in the first place -- whoops.

WebKit Commit Bot

Comment 7 2010-11-05 15:01:03 PDT

Comment on attachment 73117 [details] Patch Clearing flags on attachment: 73117 Committed r71452: <http://trac.webkit.org/changeset/71452>

WebKit Commit Bot

Comment 8 2010-11-05 15:01:09 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.