Summary: | Web Inspector: use mimeType from cached resource in case response data contains none. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Pavel Feldman <pfeldman> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Pavel Feldman
2010-11-01 12:05:44 PDT
Someone just opened the following a few days ago: <http://webkit.org/b/48525> Web Inspector: Incorrectly reports warning on missing/incorrect content-type for 304s Is this a duplicate? Created attachment 72539 [details]
[PATCH] Proposed fix.
Hard to tell since the original report references localhost :) But we have good chances of fixing that issue once this patch lands. Created attachment 72550 [details]
[PATCH] A cleaner patch.
Comment on attachment 72550 [details]
[PATCH] A cleaner patch.
lol, I was just going to suggest that exact change after looking at your first patch. Thanks for making it clearer. You could save a null check by moving this into the "if (cachedResource)" block above, but this is very readable.
Oh, and it would be awesome if you could check if this fixes bug 48525 after landing. Comment on attachment 72550 [details] [PATCH] A cleaner patch. Committing to http://svn.webkit.org/repository/webkit/trunk M WebCore/ChangeLog M WebCore/inspector/InspectorResourceAgent.cpp M WebCore/inspector/front-end/NetworkPanel.js Committed r71108 |