Bug 48767

Summary:

[Qt] QtTestBrowser : set mmp rule pageddata in Symbian

Product:

WebKit

Reporter:

Dinu Jacob <dinu.jacob>

Component:

Tools / Tests

Assignee:

George Guo <george.guo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ademar, commit-queue, george.guo, suresh.voruganti

Priority:

Version:

528+ (Nightly build)

Hardware:

S60 Hardware

OS:

S60 3rd edition

Bug Depends on:

Bug Blocks:

47918

Attachments:

Description	Flags
adding paged memory will resolve this issue	kling: review-
Added why to the patch in addtion to what as reviewer suggested	kling: review+, commit-queue: commit-queue-
Not sure why last patch failed in commit. Remake a patch	none

Dinu Jacob

Reported 2010-11-01 11:00:22 PDT

QtTestBrowser runs out of memory with most of javascript benchmarks (for example, Dromaeo ). On Symbian it improves memory consumption when pageddata is enabled.

Attachments
adding paged memory will resolve this issue (998 bytes, patch) 2010-11-02 07:23 PDT, George Guo	kling: review-	Details Formatted Diff Diff
Added why to the patch in addtion to what as reviewer suggested (1.13 KB, patch) 2010-11-02 14:58 PDT, George Guo	kling: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Not sure why last patch failed in commit. Remake a patch (1.13 KB, patch) 2010-11-03 05:32 PDT, George Guo	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

George Guo

Comment 1 2010-11-01 11:26:29 PDT

agreed with Dinu to fix this.

George Guo

Comment 2 2010-11-02 07:23:14 PDT

Created attachment 72663 [details] adding paged memory will resolve this issue

Andreas Kling

Comment 3 2010-11-02 08:29:16 PDT

Comment on attachment 72663 [details] adding paged memory will resolve this issue View in context: https://bugs.webkit.org/attachment.cgi?id=72663&action=review > WebKitTools/ChangeLog:5 > + [Qt] QtTestBrowser : set mmp rule pageddata in Symbian This ChangeLog entry only covers the "What?" - we also need the "Why?" Why is this change needed?

George Guo

Comment 4 2010-11-02 14:36:23 PDT

Paing is needed on Symbian devices to support benchmarks test like dromaeo.com and Celtic Kane that need a lot of memory to run.

George Guo

Comment 5 2010-11-02 14:58:21 PDT

Created attachment 72744 [details] Added why to the patch in addtion to what as reviewer suggested Made changes to answer why as reviewer suggested.

Andreas Kling

Comment 6 2010-11-03 01:19:49 PDT

Comment on attachment 72744 [details] Added why to the patch in addtion to what as reviewer suggested LGTM

WebKit Commit Bot

Comment 7 2010-11-03 01:22:23 PDT

Comment on attachment 72744 [details] Added why to the patch in addtion to what as reviewer suggested Rejecting patch 72744 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'apply-attachment', '--force-clean', '--non-interactive', 72744]" exit_code: 2 Last 500 characters of output: rom bug 48767. Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Andreas Kling', u'--force']" exit_code: 2 Parsed 2 diffs from patch file(s). patching file WebKitTools/ChangeLog patch: **** malformed patch at line 18: 2010-11-01 Jenn Braithwaite <jennb@chromium.org> patching file WebKitTools/QtTestBrowser/QtTestBrowser.pro Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Andreas Kling', u'--force']" exit_code: 2 Full output: http://queues.webkit.org/results/5036015

George Guo

Comment 8 2010-11-03 04:46:04 PDT

Thanks for the patience, i'm fixing the format and preparing the patch

George Guo

Comment 9 2010-11-03 05:32:58 PDT

Created attachment 72814 [details] Not sure why last patch failed in commit. Remake a patch

Andreas Kling

Comment 10 2010-11-03 05:39:53 PDT

Comment on attachment 72814 [details] Not sure why last patch failed in commit. Remake a patch Let's try again. In the future, please tick the "patch" checkbox when uploading patches :)

Suresh Voruganti

Comment 11 2010-11-03 05:49:47 PDT

This patch is required for Qtwebkit 2.1 for increasing Browser stability, so adding dependency to 39121.

WebKit Commit Bot

Comment 12 2010-11-03 20:40:22 PDT

Comment on attachment 72814 [details] Not sure why last patch failed in commit. Remake a patch Clearing flags on attachment: 72814 Committed r71302: <http://trac.webkit.org/changeset/71302>

WebKit Commit Bot

Comment 13 2010-11-03 20:40:28 PDT

All reviewed patches have been landed. Closing bug.

Ademar Reis

Comment 14 2010-11-04 09:20:21 PDT

Revision r71302 cherry-picked into qtwebkit-2.1 with commit 68f99d0 <http://gitorious.org/webkit/qtwebkit/commit/68f99d0>

Note You need to log in before you can comment on or make changes to this bug.