| Summary: | [Qt] QtTestBrowser : set mmp rule pageddata in Symbian | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dinu Jacob <dinu.jacob> | ||||||||
| Component: | Tools / Tests | Assignee: | George Guo <george.guo> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ademar, commit-queue, george.guo, suresh.voruganti | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | S60 Hardware | ||||||||||
| OS: | S60 3rd edition | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 47918 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Dinu Jacob
2010-11-01 11:00:22 PDT
agreed with Dinu to fix this. Created attachment 72663 [details]
adding paged memory will resolve this issue
Comment on attachment 72663 [details] adding paged memory will resolve this issue View in context: https://bugs.webkit.org/attachment.cgi?id=72663&action=review > WebKitTools/ChangeLog:5 > + [Qt] QtTestBrowser : set mmp rule pageddata in Symbian This ChangeLog entry only covers the "What?" - we also need the "Why?" Why is this change needed? Paing is needed on Symbian devices to support benchmarks test like dromaeo.com and Celtic Kane that need a lot of memory to run. Created attachment 72744 [details]
Added why to the patch in addtion to what as reviewer suggested
Made changes to answer why as reviewer suggested.
Comment on attachment 72744 [details]
Added why to the patch in addtion to what as reviewer suggested
LGTM
Comment on attachment 72744 [details] Added why to the patch in addtion to what as reviewer suggested Rejecting patch 72744 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'apply-attachment', '--force-clean', '--non-interactive', 72744]" exit_code: 2 Last 500 characters of output: rom bug 48767. Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Andreas Kling', u'--force']" exit_code: 2 Parsed 2 diffs from patch file(s). patching file WebKitTools/ChangeLog patch: **** malformed patch at line 18: 2010-11-01 Jenn Braithwaite <jennb@chromium.org> patching file WebKitTools/QtTestBrowser/QtTestBrowser.pro Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Andreas Kling', u'--force']" exit_code: 2 Full output: http://queues.webkit.org/results/5036015 Thanks for the patience, i'm fixing the format and preparing the patch Created attachment 72814 [details]
Not sure why last patch failed in commit. Remake a patch
Comment on attachment 72814 [details]
Not sure why last patch failed in commit. Remake a patch
Let's try again. In the future, please tick the "patch" checkbox when uploading patches :)
This patch is required for Qtwebkit 2.1 for increasing Browser stability, so adding dependency to 39121. Comment on attachment 72814 [details] Not sure why last patch failed in commit. Remake a patch Clearing flags on attachment: 72814 Committed r71302: <http://trac.webkit.org/changeset/71302> All reviewed patches have been landed. Closing bug. Revision r71302 cherry-picked into qtwebkit-2.1 with commit 68f99d0 <http://gitorious.org/webkit/qtwebkit/commit/68f99d0> |