| Summary: | [Qt] Need to implement WebKit::pluginWillHandleLoadError for WebKit2 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||
| Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | benjamin, commit-queue, kling | ||||
| Priority: | P1 | Keywords: | Qt, QtTriaged | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Adam Roben (:aroben)
2010-11-01 09:44:30 PDT
Created attachment 73737 [details]
Add the missing error.
Untested (I don't have phonon).
Comment on attachment 73737 [details]
Add the missing error.
r=me
Comment on attachment 73737 [details] Add the missing error. Rejecting patch 73737 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', 73737]" exit_code: 2 Last 500 characters of output: s Kling', u'--force']" exit_code: 1 Parsed 4 diffs from patch file(s). patching file WebKit/qt/ChangeLog patching file WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp patching file WebKit2/ChangeLog Hunk #1 FAILED at 1. 1 out of 1 hunk FAILED -- saving rejects to file WebKit2/ChangeLog.rej patching file WebKit2/WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp Failed to run "[u'/Users/abarth/git/webkit-queue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Andreas Kling', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/5774027 Committed r71938: <http://trac.webkit.org/changeset/71938> Damn, commit-log-editor failed me over the commit message. :( Sorry about that. |