Summary: | Web Inspector: [Extensions API] expose API to create properties watch sidebar panes | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andrey Kosyakov <caseq> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Andrey Kosyakov <caseq> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, yurys | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Andrey Kosyakov
2010-11-01 08:45:34 PDT
Created attachment 72515 [details]
patch
Comment on attachment 72515 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=72515&action=review > WebCore/inspector/front-end/ExtensionAPI.js:271 > + setObject: function(expression, rootTitle) expression -> jsonObject > WebCore/inspector/front-end/ExtensionPanel.js:118 > +WebInspector.LocalJSONObject = function(value) I'd suggest that you move LocalJSONObject into RemoteObject.js and update the factory method there. Created attachment 72528 [details]
patch to land
- Moved LocalJSONObject to RemoteObject.js, added RemoteObject.fromLocalObject()
- setObject(expression,...) => setObject(jsonObject,...)
Comment on attachment 72515 [details] patch Cleared Pavel Feldman's review+ from obsolete attachment 72515 [details] so that this bug does not appear in http://webkit.org/pending-commit. Patch laneded at r71107: http://trac.webkit.org/changeset/71107 |