Bug 48759

Summary: [GTK] Cleanup needed in testatk.c file
Product: WebKit Reporter: Mario Sanchez Prada <mario>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch proposal mrobinson: review+

Mario Sanchez Prada
Reported 2010-11-01 08:23:30 PDT
Currently, this file is not very coherent in its content since some parts of it are written in an old-fashioned (not WebKit's coding-style compliant) way and some other, newer, parts are written in a completely different style. On top of that, there's currently the "new trend" in the file of avoiding using an extra main loop in each test by just manually spinning the original main loop before trying to retrieve the accessible objects, which would be more than enough for the tests for properly work. As a consequence, it would be nice to make some cleanup in this file to prepare it for further modifications, in a way so the whole file uses consistent style and patterns for the unit tests infrastructure. I have a patch almost ready, attaching it in a while...
Attachments
Patch proposal (70.91 KB, patch)
2010-11-01 08:41 PDT, Mario Sanchez Prada 		mrobinson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mario Sanchez Prada
Comment 1 2010-11-01 08:24:33 PDT
Adding Martin to CC, as he already showed interest on this matter
Mario Sanchez Prada
Comment 2 2010-11-01 08:41:46 PDT
Created attachment 72510 [details] Patch proposal Attaching patch proposal. Asking for review
Mario Sanchez Prada
Comment 3 2010-11-01 14:00:44 PDT
Committed r71052: <http://trac.webkit.org/changeset/71052>
Note You need to log in before you can comment on or make changes to this bug.