Bug 48725

Summary: Web Inspector: unhide new network and resources panels.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, bweinstein, eric, joepeck, keishi, loislo, peter, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed change.
none
[PATCH] Same with Web Sockets filter fix. timothy: review+

Description Pavel Feldman 2010-10-31 04:54:49 PDT
There still is enough room for polish, but I'd like to enable it early in order to get the feedback.
Comment 1 Pavel Feldman 2010-10-31 05:17:50 PDT
Created attachment 72453 [details]
[PATCH] Proposed change.
Comment 2 Pavel Feldman 2010-10-31 14:43:57 PDT
Created attachment 72478 [details]
[PATCH] Same with Web Sockets filter fix.
Comment 3 Timothy Hatcher 2010-10-31 15:48:43 PDT
Comment on attachment 72478 [details]
[PATCH] Same with Web Sockets filter fix.

View in context: https://bugs.webkit.org/attachment.cgi?id=72478&action=review

> WebCore/inspector/front-end/StoragePanel.js:1103
> +        return "fs://" + encodeURI(this._origin);

Better as "file-system://" I think.
Comment 4 Pavel Feldman 2010-11-01 00:21:13 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/http/tests/inspector/console-xhr-logging-expected.txt
	M	LayoutTests/http/tests/inspector/resource-parameters-expected.txt
	M	LayoutTests/inspector/elements-panel-styles-expected.txt
	M	WebCore/ChangeLog
	M	WebCore/English.lproj/localizedStrings.js
	M	WebCore/inspector/InspectorController.h
	M	WebCore/inspector/front-end/NetworkPanel.js
	M	WebCore/inspector/front-end/Resource.js
	M	WebCore/inspector/front-end/ResourceManager.js
	M	WebCore/inspector/front-end/Settings.js
	M	WebCore/inspector/front-end/StoragePanel.js
	M	WebCore/inspector/front-end/inspector.js
	M	WebCore/inspector/front-end/networkPanel.css
	M	WebKit/chromium/ChangeLog
	M	WebKit/chromium/src/WebDevToolsAgentImpl.cpp
Committed r71010
Comment 5 WebKit Review Bot 2010-11-01 00:42:31 PDT
http://trac.webkit.org/changeset/71010 might have broken SnowLeopard Intel Release (Tests)
The following tests are not passing:
inspector/console-log-syntax-error.html