Bug 48725

Summary:

Web Inspector: unhide new network and resources panels.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Feldman <pfeldman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, apavlov, bweinstein, eric, joepeck, keishi, loislo, peter, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed change.	none
[PATCH] Same with Web Sockets filter fix.	timothy: review+

Pavel Feldman

Reported 2010-10-31 04:54:49 PDT

There still is enough room for polish, but I'd like to enable it early in order to get the feedback.

Attachments
[PATCH] Proposed change. (21.93 KB, patch) 2010-10-31 05:17 PDT, Pavel Feldman	no flags	Details Formatted Diff Diff
[PATCH] Same with Web Sockets filter fix. (27.73 KB, patch) 2010-10-31 14:43 PDT, Pavel Feldman	timothy: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2010-10-31 05:17:50 PDT

Created attachment 72453 [details] [PATCH] Proposed change.

Pavel Feldman

Comment 2 2010-10-31 14:43:57 PDT

Created attachment 72478 [details] [PATCH] Same with Web Sockets filter fix.

Timothy Hatcher

Comment 3 2010-10-31 15:48:43 PDT

Comment on attachment 72478 [details] [PATCH] Same with Web Sockets filter fix. View in context: https://bugs.webkit.org/attachment.cgi?id=72478&action=review > WebCore/inspector/front-end/StoragePanel.js:1103 > + return "fs://" + encodeURI(this._origin); Better as "file-system://" I think.

Pavel Feldman

Comment 4 2010-11-01 00:21:13 PDT

Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/http/tests/inspector/console-xhr-logging-expected.txt M LayoutTests/http/tests/inspector/resource-parameters-expected.txt M LayoutTests/inspector/elements-panel-styles-expected.txt M WebCore/ChangeLog M WebCore/English.lproj/localizedStrings.js M WebCore/inspector/InspectorController.h M WebCore/inspector/front-end/NetworkPanel.js M WebCore/inspector/front-end/Resource.js M WebCore/inspector/front-end/ResourceManager.js M WebCore/inspector/front-end/Settings.js M WebCore/inspector/front-end/StoragePanel.js M WebCore/inspector/front-end/inspector.js M WebCore/inspector/front-end/networkPanel.css M WebKit/chromium/ChangeLog M WebKit/chromium/src/WebDevToolsAgentImpl.cpp Committed r71010

WebKit Review Bot

Comment 5 2010-11-01 00:42:31 PDT

http://trac.webkit.org/changeset/71010 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: inspector/console-log-syntax-error.html

Note You need to log in before you can comment on or make changes to this bug.