Bug 48725 - Web Inspector: unhide new network and resources panels.
Summary: Web Inspector: unhide new network and resources panels.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
Depends on:
Reported: 2010-10-31 04:54 PDT by Pavel Feldman
Modified: 2010-11-01 00:42 PDT (History)
14 users (show)

See Also:

[PATCH] Proposed change. (21.93 KB, patch)
2010-10-31 05:17 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff
[PATCH] Same with Web Sockets filter fix. (27.73 KB, patch)
2010-10-31 14:43 PDT, Pavel Feldman
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2010-10-31 04:54:49 PDT
There still is enough room for polish, but I'd like to enable it early in order to get the feedback.
Comment 1 Pavel Feldman 2010-10-31 05:17:50 PDT
Created attachment 72453 [details]
[PATCH] Proposed change.
Comment 2 Pavel Feldman 2010-10-31 14:43:57 PDT
Created attachment 72478 [details]
[PATCH] Same with Web Sockets filter fix.
Comment 3 Timothy Hatcher 2010-10-31 15:48:43 PDT
Comment on attachment 72478 [details]
[PATCH] Same with Web Sockets filter fix.

View in context: https://bugs.webkit.org/attachment.cgi?id=72478&action=review

> WebCore/inspector/front-end/StoragePanel.js:1103
> +        return "fs://" + encodeURI(this._origin);

Better as "file-system://" I think.
Comment 4 Pavel Feldman 2010-11-01 00:21:13 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/http/tests/inspector/console-xhr-logging-expected.txt
	M	LayoutTests/http/tests/inspector/resource-parameters-expected.txt
	M	LayoutTests/inspector/elements-panel-styles-expected.txt
	M	WebCore/ChangeLog
	M	WebCore/English.lproj/localizedStrings.js
	M	WebCore/inspector/InspectorController.h
	M	WebCore/inspector/front-end/NetworkPanel.js
	M	WebCore/inspector/front-end/Resource.js
	M	WebCore/inspector/front-end/ResourceManager.js
	M	WebCore/inspector/front-end/Settings.js
	M	WebCore/inspector/front-end/StoragePanel.js
	M	WebCore/inspector/front-end/inspector.js
	M	WebCore/inspector/front-end/networkPanel.css
	M	WebKit/chromium/ChangeLog
	M	WebKit/chromium/src/WebDevToolsAgentImpl.cpp
Committed r71010
Comment 5 WebKit Review Bot 2010-11-01 00:42:31 PDT
http://trac.webkit.org/changeset/71010 might have broken SnowLeopard Intel Release (Tests)
The following tests are not passing: