Bug 48721
| Summary: | Incremental builds fail on Windows if WebKit.idl is not touched but some other IDL is changed | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Antonio Gomes <tonikitoo> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | aroben, eric |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
Antonio Gomes
http://trac.webkit.org/changeset/70975 was an example of that.
It added an enum value in WebKit/win/Interfaces/IWebPreferences.idl ('WebKitEditingUnixBehavior'), but incremental windows bots builds were failing to build as seen in
http://build.webkit.org/builders/Windows%20Debug%20%28Build%29 .
(...)
LayoutTestControllerWin.cpp
.\LayoutTestControllerWin.cpp(1389) : error C2065:
'WebKitEditingUnixBehavior' : undeclared identifier
(....)
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adam Roben (:aroben)
Thanks for reporting this. It's a long-standing issue.
It seems like it would be easy to fix by having a script run during InterfacesGenerated that compares the mod-dates of all the IDL files and touches WebKit.idl if any of them are newer than it.
Eric Seidel (no email)
I'm glad we get these written down. It's very important to fix these issues for the long-term health of our bots.
Antonio Gomes
*** This bug has been marked as a duplicate of bug 32127 ***