Summary: | [Qt] Support nodesFromRect in DRT | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Robert Hogan <robert> | ||||||
Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, commit-queue, eric, kling, ossy, tonikitoo, webkit.review.bot | ||||||
Priority: | P2 | Keywords: | Qt, QtTriaged | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Robert Hogan
2010-10-30 06:31:08 PDT
Created attachment 72434 [details]
Patch
Comment on attachment 72434 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=72434&action=review > WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:797 > + RefPtr<NodeList> nodes = doc->nodesFromRect(x, y, top, right, bottom, left, ignoreClipping); > + for (int i = 0; i < nodes->length(); i++) { > + QVariant v; > + v.setValue(QWebElement(nodes->item(i))); what happens if nodes->item(i) is a text node? i.e. not a WebCore::Element* Comment on attachment 72434 [details] Patch Please add a comment about the known problem on comment #2. Andreas, what do you think? Change to qt_runtime ok? Created attachment 72439 [details]
Patch
Comment on attachment 72439 [details] Patch Clearing flags on attachment: 72439 Committed r71004: <http://trac.webkit.org/changeset/71004> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/71004 might have broken Qt Linux Release The following tests are not passing: fast/dom/nodesFromRect-basic.html (In reply to comment #8) > http://trac.webkit.org/changeset/71004 might have broken Qt Linux Release > The following tests are not passing: > fast/dom/nodesFromRect-basic.html worked locally for me: $ WEBKITOUTPUTDIR=`pwd`/WebKitBuild/Qt/ run-webkit-tests --qt LayoutTests/fast/dom/nodesFromRect-basic.html Running build-dumprendertree Running tests from /home/agomes/Devel/webkit/webkit/LayoutTests Testing 1 test cases. fast/dom . 1.80s total testing time all 1 test cases succeeded New bug filed on this fail: https://bugs.webkit.org/show_bug.cgi?id=48758 |