Bug 48713

Summary:

[GTK] Add support for <meter> element

Product:

WebKit

Reporter:

Yael <yael>

Component:

DOM

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, cgarcia, dbates, eric, joone, mrobinson, webkit.review.bot

Priority:

Keywords:

Gtk, PlatformOnly

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
Enable meter element in gtk port	none
Updated patch	none

Yael

Reported 2010-10-30 06:07:17 PDT

Need to add support for <meter> element in RenderThemeGtk.cpp

Attachments
Enable meter element in gtk port (55.85 KB, patch) 2010-12-24 03:26 PST, Carlos Garcia Campos	no flags	Details Formatted Diff Diff
Updated patch (55.91 KB, patch) 2010-12-27 04:10 PST, Carlos Garcia Campos	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Martin Robinson

Comment 1 2010-10-30 08:09:22 PDT

I can tackle this, if no one else has plans to.

Carlos Garcia Campos

Comment 2 2010-12-24 03:26:15 PST

Created attachment 77410 [details] Enable meter element in gtk port We don't need any specific code in RenderThemeGtk. Gtk+ doesn't have a meter widget so there's no way to render them like gtk+. Using the default meter defined in html.css makes exactly the same output than chromium, for example, which I think is acceptable for gtk+ too.

Martin Robinson

Comment 3 2010-12-24 10:49:45 PST

Awesome! Thanks Carlos. Are these results for GTK+ 3.x or 2.x? We should also include pixel dumps.

Daniel Bates

Comment 4 2010-12-24 12:41:40 PST

Comment on attachment 77410 [details] Enable meter element in gtk port View in context: https://bugs.webkit.org/attachment.cgi?id=77410&action=review > WebCore/GNUmakefile.am:3895 > # HTML Meter Element - disable for now. This comment should be updated. In particular, the phrase "disabled for now." should be removed.

Carlos Garcia Campos

Comment 5 2010-12-27 03:38:57 PST

(In reply to comment #3) > Awesome! Thanks Carlos. Are these results for GTK+ 3.x or 2.x? We should also include pixel dumps. Both, since we are not using gtk.

Carlos Garcia Campos

Comment 6 2010-12-27 04:10:03 PST

Created attachment 77490 [details] Updated patch Updated patch just updating the comment in Makefile as suggested by Daniel Bates

Martin Robinson

Comment 7 2010-12-27 08:54:59 PST

Comment on attachment 77490 [details] Updated patch Thanks! Please attach pixel results to this patch before landing it.

Carlos Garcia Campos

Comment 8 2011-01-11 09:32:46 PST

Committed r75507: <http://trac.webkit.org/changeset/75507>

WebKit Review Bot

Comment 9 2011-01-11 10:38:28 PST

http://trac.webkit.org/changeset/75507 might have broken GTK Linux 64-bit Debug The following tests are not passing: fast/dom/HTMLMeterElement/meter-appearances-capacity.html fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy.html fast/dom/HTMLMeterElement/meter-boundary-values.html fast/dom/HTMLMeterElement/meter-element-crash.html fast/dom/HTMLMeterElement/meter-element-form.html fast/dom/HTMLMeterElement/meter-element-with-child-crash.html fast/dom/HTMLMeterElement/meter-element.html fast/dom/HTMLMeterElement/meter-optimums.html fast/dom/HTMLMeterElement/meter-percent-size.html fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html fast/dom/HTMLMeterElement/meter-styles.html fast/dom/HTMLMeterElement/set-meter-properties.html fast/forms/form-attribute.html

Note You need to log in before you can comment on or make changes to this bug.