Bug 48700

Summary: [Qt] IM: Don't manipulate selection via RenderTextControl
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebKit QtAssignee: QtWebKit Unassigned <webkit-qt-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, rniwa, tkent
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch none

Andreas Kling
Reported 2010-10-29 17:16:53 PDT
As brought up by Ryosuke Niwa on IRC, Qt's Input Method API shouldn't be accessing the selection through RenderTextControl. We should go directly through the Frame's SelectionController instead.
Attachments
Proposed patch (4.70 KB, patch)
2010-10-29 17:18 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2010-10-29 17:18:26 PDT
Created attachment 72417 [details] Proposed patch
Andreas Kling
Comment 2 2010-10-30 07:51:43 PDT
Comment on attachment 72417 [details] Proposed patch Clearing flags on attachment: 72417 Committed r70982: <http://trac.webkit.org/changeset/70982>
Andreas Kling
Comment 3 2010-10-30 07:51:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.