Bug 48700

Summary:

[Qt] IM: Don't manipulate selection via RenderTextControl

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

WebKit Qt

Assignee:

QtWebKit Unassigned <webkit-qt-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, rniwa, tkent

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed patch	none

Description Andreas Kling 2010-10-29 17:16:53 PDT

As brought up by Ryosuke Niwa on IRC, Qt's Input Method API shouldn't be accessing the selection through RenderTextControl.
We should go directly through the Frame's SelectionController instead.

Comment 1 Andreas Kling 2010-10-29 17:18:26 PDT

Created attachment 72417 [details]
Proposed patch

Comment 2 Andreas Kling 2010-10-30 07:51:43 PDT

Comment on attachment 72417 [details]
Proposed patch

Clearing flags on attachment: 72417

Committed r70982: <http://trac.webkit.org/changeset/70982>

Comment 3 Andreas Kling 2010-10-30 07:51:54 PDT

All reviewed patches have been landed.  Closing bug.