Bug 48692

Summary: [Qt] QWebPage's InputMethod event handling calls ShortcutOverride handler too
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebKit QtAssignee: QtWebKit Unassigned <webkit-qt-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ademar
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch
none
Proposed patch none

Description Andreas Kling 2010-10-29 15:31:33 PDT
Due to a missing break statement, QWebPage::event() falls through to QEvent::ShortcutOverride after handling QEvent::InputMethod and calls shortCutOverrideEvent() with a QInputMethodEvent cast to a QKeyEvent. Oops!
Comment 1 Andreas Kling 2010-10-29 15:32:55 PDT
Created attachment 72408 [details]
Proposed patch
Comment 2 Andreas Kling 2010-10-29 16:10:36 PDT
Created attachment 72413 [details]
Proposed patch

Ahem..
Comment 3 Ariya Hidayat 2010-10-29 16:23:14 PDT
Comment on attachment 72413 [details]
Proposed patch

LGTM.
Comment 4 Andreas Kling 2010-10-29 16:25:04 PDT
Comment on attachment 72413 [details]
Proposed patch

Clearing flags on attachment: 72413

Committed r70948: <http://trac.webkit.org/changeset/70948>
Comment 5 Andreas Kling 2010-10-29 16:25:13 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Andreas Kling 2010-10-29 16:28:54 PDT
Blocking 2.1 on this since it's trivial and obviously fixes a bug.
Comment 7 Ademar Reis 2010-11-03 10:23:48 PDT
Revision r70948 cherry-picked into qtwebkit-2.1 with commit 0e4d96b <http://gitorious.org/webkit/qtwebkit/commit/0e4d96b>