Bug 48692

Summary: [Qt] QWebPage's InputMethod event handling calls ShortcutOverride handler too
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebKit QtAssignee: QtWebKit Unassigned <webkit-qt-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ademar
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch
none
Proposed patch none

Andreas Kling
Reported 2010-10-29 15:31:33 PDT
Due to a missing break statement, QWebPage::event() falls through to QEvent::ShortcutOverride after handling QEvent::InputMethod and calls shortCutOverrideEvent() with a QInputMethodEvent cast to a QKeyEvent. Oops!
Attachments
Proposed patch (559 bytes, patch)
2010-10-29 15:32 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Proposed patch (1017 bytes, patch)
2010-10-29 16:10 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2010-10-29 15:32:55 PDT
Created attachment 72408 [details] Proposed patch
Andreas Kling
Comment 2 2010-10-29 16:10:36 PDT
Created attachment 72413 [details] Proposed patch Ahem..
Ariya Hidayat
Comment 3 2010-10-29 16:23:14 PDT
Comment on attachment 72413 [details] Proposed patch LGTM.
Andreas Kling
Comment 4 2010-10-29 16:25:04 PDT
Comment on attachment 72413 [details] Proposed patch Clearing flags on attachment: 72413 Committed r70948: <http://trac.webkit.org/changeset/70948>
Andreas Kling
Comment 5 2010-10-29 16:25:13 PDT
All reviewed patches have been landed. Closing bug.
Andreas Kling
Comment 6 2010-10-29 16:28:54 PDT
Blocking 2.1 on this since it's trivial and obviously fixes a bug.
Ademar Reis
Comment 7 2010-11-03 10:23:48 PDT
Revision r70948 cherry-picked into qtwebkit-2.1 with commit 0e4d96b <http://gitorious.org/webkit/qtwebkit/commit/0e4d96b>
Note You need to log in before you can comment on or make changes to this bug.