Bug 48672

Summary:

Make vertical hit testing for glyph offsets of InlineTextBoxes work.

Product:

WebKit

Reporter:

Dave Hyatt <hyatt>

Component:

Layout and Rendering

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

46123

Attachments:

Description	Flags
Patch	none
Patch	mitz: review+

Description Dave Hyatt 2010-10-29 14:12:19 PDT

Make vertical hit testing of InlineTextBoxes work.  Painting has been patched, but hit testing has not.

Comment 1 Dave Hyatt 2010-11-02 12:58:17 PDT

Created attachment 72720 [details]
Patch

Comment 2 Dave Hyatt 2010-11-02 13:01:13 PDT

Created attachment 72722 [details]
Patch

Comment 3 Dave Hyatt 2010-11-02 15:23:52 PDT

Fixed in r71177,

Note there were three bugs in the patch, caught by layout test failures.

(1) The top/bottomVisibleOverflows for painting/hit testing needed to be logicalTop/logicalBottom.
(2) The logicalPointEnd needed a +1 put on it (since a padding of 0 still equals an extent of 1).
(3) The rect values for hit testing were backwards.