Bug 48672

Summary: Make vertical hit testing for glyph offsets of InlineTextBoxes work.
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 46123    
Attachments:
Description Flags
Patch
none
Patch mitz: review+

Dave Hyatt
Reported 2010-10-29 14:12:19 PDT
Make vertical hit testing of InlineTextBoxes work. Painting has been patched, but hit testing has not.
Attachments
Patch (64.09 KB, patch)
2010-11-02 12:58 PDT, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
Patch (67.25 KB, patch)
2010-11-02 13:01 PDT, Dave Hyatt 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2010-11-02 12:58:17 PDT
Created attachment 72720 [details] Patch
Dave Hyatt
Comment 2 2010-11-02 13:01:13 PDT
Created attachment 72722 [details] Patch
Dave Hyatt
Comment 3 2010-11-02 15:23:52 PDT
Fixed in r71177, Note there were three bugs in the patch, caught by layout test failures. (1) The top/bottomVisibleOverflows for painting/hit testing needed to be logicalTop/logicalBottom. (2) The logicalPointEnd needed a +1 put on it (since a padding of 0 still equals an extent of 1). (3) The rect values for hit testing were backwards.
Note You need to log in before you can comment on or make changes to this bug.