Bug 48664

Summary: Make repaint invalidation work with flipped blocks ("rl" and "bt")
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 46123    
Attachments:
Description Flags
Patch
none
Patch simon.fraser: review+

Description Dave Hyatt 2010-10-29 12:35:11 PDT 
Make repaint invalidation work with flipped blocks ("rl" and "bt")
Comment 1 Dave Hyatt 2010-11-11 13:46:42 PST 
Created attachment 73652 [details]
Patch
Comment 2 Dave Hyatt 2010-11-11 13:48:22 PST 
Created attachment 73653 [details]
Patch
Comment 3 Simon Fraser (smfr) 2010-11-11 14:01:28 PST 
Comment on attachment 73653 [details]
Patch

r=me but I'd like to see more comments (as discussed on irc).
Comment 4 Dave Hyatt 2010-11-11 14:10:59 PST 
(In reply to comment #3)
> (From update of attachment 73653 [details])
> r=me but I'd like to see more comments (as discussed on irc).

I added some comments to the headers and then wrote a novella in RenderBox::computeRectForRepaint.
Comment 5 Dave Hyatt 2010-11-11 14:17:58 PST 
Fixed in r71851.
Comment 6 WebKit Review Bot 2010-11-11 14:55:24 PST 
http://trac.webkit.org/changeset/71851 might have broken SnowLeopard Intel Release (Tests)
The following tests are not passing:
fast/table/colspanMinWidth-vertical.html