Bug 48663

Summary:

Make repaint invalidation work with vertical lines.

Product:

WebKit

Reporter:

Dave Hyatt <hyatt>

Component:

Layout and Rendering

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, darin, eric, ossy, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

48731

Bug Blocks:

46123

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	mitz: review+

Description Dave Hyatt 2010-10-29 12:34:28 PDT

Make repaint invalidation work with vertical lines.

Comment 1 Dave Hyatt 2010-10-29 14:21:23 PDT

Created attachment 72393 [details]
Patch

Comment 2 Dave Hyatt 2010-10-29 14:48:04 PDT

Created attachment 72398 [details]
Patch

Comment 3 Dave Hyatt 2010-10-29 15:32:39 PDT

Created attachment 72407 [details]
Patch

Comment 4 Dave Hyatt 2010-10-29 17:39:01 PDT

Fixed in r70959.

Comment 5 WebKit Review Bot 2010-10-29 18:54:10 PDT

http://trac.webkit.org/changeset/70959 might have broken SnowLeopard Intel Release (Tests) and GTK Linux 64-bit Debug
The following tests are not passing:
fast/events/spatial-navigation/snav-clipped-overflowed-content.html
fast/events/spatial-navigation/snav-iframe-nested.html

Comment 6 Darin Adler 2010-10-30 14:33:59 PDT

I agree with the bot. After this patch, two of the spatial-navigation tests are failing on all platforms. It’s the reason there is so much red on the bots.

Hyatt, can you figure out what’s up and make the bots happy again?

Comment 7 Antonio Gomes 2010-10-31 05:47:54 PDT

(In reply to comment #6)
> I agree with the bot. After this patch, two of the spatial-navigation tests are failing on all platforms. It’s the reason there is so much red on the bots.
> 
> Hyatt, can you figure out what’s up and make the bots happy again?

They actually failed in all mac tests builds, as well as qt , gtk bots.

Hyatt, I would be glad to help fixing it too. they are still failing ...

Comment 8 Csaba Osztrogonác 2010-10-31 10:36:47 PDT

(In reply to comment #5)
> http://trac.webkit.org/changeset/70959 might have broken SnowLeopard Intel Release (Tests) and GTK Linux 64-bit Debug
> The following tests are not passing:
> fast/events/spatial-navigation/snav-clipped-overflowed-content.html
> fast/events/spatial-navigation/snav-iframe-nested.html

Rolled out by http://trac.webkit.org/changeset/70991, because t
he whole tree and commit queue were broken because of r70959.

Comment 9 Csaba Osztrogonác 2010-10-31 10:37:33 PDT

Comment on attachment 72407 [details]
Patch

remove r+ from landed and rolled-out patch

Comment 10 Dave Hyatt 2010-11-01 11:39:15 PDT

Created attachment 72530 [details]
Patch

The previous patch flipped a left and a top by accident in linesVisibleOverflowBoundingBox, and that's what caused the spatial navigation tests to fail.

Comment 11 mitz 2010-11-01 11:49:01 PDT

Comment on attachment 72530 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72530&action=review

> WebCore/ChangeLog:15
> +        * WebCore.xcodeproj/project.pbxproj:

Don’t land this change.

Comment 12 Dave Hyatt 2010-11-01 12:07:41 PDT

Fixed in r71043.

Comment 13 WebKit Review Bot 2010-11-01 12:38:37 PDT

http://trac.webkit.org/changeset/71043 might have broken SnowLeopard Intel Release (Tests)
The following tests are not passing:
fast/text/international/vertical-text-glyph-test.html